Add patches to wikiman#546
Open
outdooracorn wants to merge 3 commits into
Open
Conversation
Allow components (mediawiki, extensions, skins) in `wikiman.yaml` to define patches via a `patches` array. Patches are now preserved when wikiman regenerates `pacman.yaml`, removing the need to manually re-add them. This also makes it easier to add comments explaining what each patch does. `patches` is an array of objects so that it can support managing patches via different means in the future. E.g. the Patch object could contain a Gerrit Change Number or a Commit Hash instead of the URL. Bug: T431152
Member
Author
|
In #546, @tarrow provided some useful context on this topic. I also like the doc changes that @deer-wmde has made in that PR. Especially the changes that fix or remove the information that is outdated by this PR. |
outdooracorn
force-pushed
the
add-patches-to-wikiman
branch
from
795a5c8 to
9ca7f40
Compare
Contributor
|
@outdooracorn feel free to include those doc changes here, as the other PR won't get merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow components (mediawiki, extensions, skins) in
wikiman.yamlto define patches via apatchesarray. Patches are now preserved when wikiman regeneratespacman.yaml, removing the need to manually re-add them. This also makes it easier to add comments explaining what each patch does.patchesis an array of objects so that it can support managing patches via different means in the future. E.g. the Patch object could contain a Gerrit Change Number or a Commit Hash instead of the URL.Bug: T431152