Scope native artifact uploads to child tasks - #14963
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
Scope native artifact uploads to child tasks#14963warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Warp Agent <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix native
upload_artifactcalls that resolved a local child association but omitted its ambient task identity from artifact GraphQL requests.The artifact uploader now requires the resolved task ID for both upload-target creation and confirmation, and sends it through request-local GraphQL header policy. This removes the CLI's shared
ServerApitask-ID mutation, so concurrent local children cannot race by overwriting ambient task context. Server authorization behavior is unchanged.Linked Issue
No linked issue.
Testing
cargo test -p warp --lib ai::agent_sdk::artifact_upload::tests(16 passed)cargo test -p warp_server_client authenticated_graphql_options_can_override_task_id_for_one_requestcargo test -p warp_server_client base_client::tests::ambient_policy_supports_inherit_override_and_omit./script/format --check./script/check_no_inline_test_modulescargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningscargo clippy -p warp --all-targets --tests -- -D warnings./script/run— not applicable to this non-UI request-header change.Cross-platform cloud verification was skipped because the final diff is platform-agnostic Rust/GraphQL header plumbing with no OS- or architecture-specific code, path behavior, native dependencies, ABI, or packaging changes.
Agent Mode
CHANGELOG-BUG-FIX: Attach native artifact uploads to the correct local child task.
Co-Authored-By: Warp Agent agent@warp.dev
Conversation: https://staging.warp.dev/conversation/bc181c55-ba82-40ae-99f4-76e7b8de461f
Run: https://oz.staging.warp.dev/runs/019ff287-bb8d-7d93-b349-a39904e21727
This PR was generated with Oz.