Skip to content

Remove unused defaultEnabledValue field from CodebaseContextPolicy schema - #14953

Draft
warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
remove-defaultEnabledValue-codebase-context-policy
Draft

Remove unused defaultEnabledValue field from CodebaseContextPolicy schema#14953
warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
remove-defaultEnabledValue-codebase-context-policy

Conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Description

Removes the unused defaultEnabledValue: Boolean! field from type CodebaseContextPolicy in the client's checked-in copy of the server schema (crates/warp_graphql_schema/api/schema.graphql), per a Slack request from @tylerlam-warp.

Linked Issue

No GitHub issue exists for this; the request came from Slack (thread 1786474805.001679 in C0BDQDW8V5E). Skipping the issue-label checklist below since there's no issue to link.

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • N/A — no user-visible/UI change, so no screenshots needed.

Safety analysis

Verdict: safe. The field is already dead on both sides of the wire.

What I checked, and the evidence:

  • Is this schema file generated or hand-maintained? It's a checked-in artifact produced by manually running the graphql-codegen/schema-ast pipeline in crates/warp_graphql_schema/graphql.config.js against a live server (staging or local) — build.rs only compiles Rust types from whatever is already committed; it never re-fetches. There is no CI job that diffs this file against the live server schema, so drift isn't automatically caught. In fact this file is already stale: defaultEnabledValue was dropped from the server's CodebaseContextPolicy on Aug 4, 2026 (warp-server 860c6d45c, "Codebase context: enforce tri-state admin setting..."), but the most recent commit to touch this file in warp (e8cb7b4e, Aug 8) only added an unrelated field (attributedTeamUid) and didn't remove this one — confirming updates here are partial/manual rather than full automatic resyncs.
  • Does the server still serve this field? No. warp-server/graphql/v2/billing.graphqls's CodebaseContextPolicy type has no defaultEnabledValue field, and neither does the generated Go (graphql/v2/generated/billing.generated.go) or the config loader (billing/billing_config.go). It was deliberately removed in warp-server PR Hide the outer agent bar when the Warp TUI runs in a pane #13738.
  • Does the client select or depend on it? No. Searched the whole warp repo for defaultEnabledValue / default_enabled_value (Rust field names, .graphql query/fragment documents, generated code) — the only occurrence anywhere was this schema line. The cynic QueryFragment for CodebaseContextPolicy (crates/graphql/src/api/billing.rs) never selected this field, and app/src/workspaces/gql_convert.rs / workspace.rs have no reference to it either.
  • History: warp-server Hide the outer agent bar when the Warp TUI runs in a pane #13738 replaced the boolean default_enabled_value policy field with tri-state admin-setting resolution (unset now resolves to RESPECT_USER_SETTING), so the field became fully redundant server-side.

Residual risk: since this file has no automated drift check, a future manual full-resync against a live (post-#13738) server would also omit this field — i.e. this change is consistent with, not fighting, the next regeneration.

Testing

No client code changed beyond the schema file (nothing referenced the removed field). Validated:

  • cargo check -p warp_graphql_schema -p warp_graphql -p warp — compiles clean.
  • ./script/format — no changes needed beyond the edit itself.
  • cargo clippy -p warp_graphql_schema -p warp_graphql -p warp --all-targets --tests -- -D warnings — clean.

No behavior changes and no UI surface touched, so no manual/UI testing or screenshots apply.

  • I have manually tested my changes locally with ./script/run — N/A, see above; verified via cargo check/clippy instead since there is no runtime behavior to exercise.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Conversation: https://staging.warp.dev/conversation/bf2bfec5-b6f8-4029-a68d-437f1eff95ce
Run: https://oz.staging.warp.dev/runs/019ff234-cd04-72ac-9d0b-817fe25ac484

This PR was generated with Oz.

…hema

The server stopped serving this field in warp-server#13738 (Aug 4,
2026), which enforced a tri-state admin setting for codebase context
instead. No client code selects or depends on this field (no cynic
QueryFragment references it), so this brings the checked-in schema
back in sync with what the server actually serves.

Co-Authored-By: Warp Agent <agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant