Remove unused defaultEnabledValue field from CodebaseContextPolicy schema - #14953
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
Remove unused defaultEnabledValue field from CodebaseContextPolicy schema#14953warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
…hema The server stopped serving this field in warp-server#13738 (Aug 4, 2026), which enforced a tri-state admin setting for codebase context instead. No client code selects or depends on this field (no cynic QueryFragment references it), so this brings the checked-in schema back in sync with what the server actually serves. Co-Authored-By: Warp Agent <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the unused
defaultEnabledValue: Boolean!field fromtype CodebaseContextPolicyin the client's checked-in copy of the server schema (crates/warp_graphql_schema/api/schema.graphql), per a Slack request from @tylerlam-warp.Linked Issue
No GitHub issue exists for this; the request came from Slack (thread
1786474805.001679inC0BDQDW8V5E). Skipping the issue-label checklist below since there's no issue to link.ready-to-specorready-to-implement.Safety analysis
Verdict: safe. The field is already dead on both sides of the wire.
What I checked, and the evidence:
graphql-codegen/schema-astpipeline incrates/warp_graphql_schema/graphql.config.jsagainst a live server (staging or local) —build.rsonly compiles Rust types from whatever is already committed; it never re-fetches. There is no CI job that diffs this file against the live server schema, so drift isn't automatically caught. In fact this file is already stale:defaultEnabledValuewas dropped from the server'sCodebaseContextPolicyon Aug 4, 2026 (warp-server860c6d45c, "Codebase context: enforce tri-state admin setting..."), but the most recent commit to touch this file inwarp(e8cb7b4e, Aug 8) only added an unrelated field (attributedTeamUid) and didn't remove this one — confirming updates here are partial/manual rather than full automatic resyncs.warp-server/graphql/v2/billing.graphqls'sCodebaseContextPolicytype has nodefaultEnabledValuefield, and neither does the generated Go (graphql/v2/generated/billing.generated.go) or the config loader (billing/billing_config.go). It was deliberately removed in warp-server PR Hide the outer agent bar when the Warp TUI runs in a pane #13738.warprepo fordefaultEnabledValue/default_enabled_value(Rust field names,.graphqlquery/fragment documents, generated code) — the only occurrence anywhere was this schema line. The cynicQueryFragmentforCodebaseContextPolicy(crates/graphql/src/api/billing.rs) never selected this field, andapp/src/workspaces/gql_convert.rs/workspace.rshave no reference to it either.default_enabled_valuepolicy field with tri-state admin-setting resolution (unset now resolves toRESPECT_USER_SETTING), so the field became fully redundant server-side.Residual risk: since this file has no automated drift check, a future manual full-resync against a live (post-#13738) server would also omit this field — i.e. this change is consistent with, not fighting, the next regeneration.
Testing
No client code changed beyond the schema file (nothing referenced the removed field). Validated:
cargo check -p warp_graphql_schema -p warp_graphql -p warp— compiles clean../script/format— no changes needed beyond the edit itself.cargo clippy -p warp_graphql_schema -p warp_graphql -p warp --all-targets --tests -- -D warnings— clean.No behavior changes and no UI surface touched, so no manual/UI testing or screenshots apply.
./script/run— N/A, see above; verified viacargo check/clippyinstead since there is no runtime behavior to exercise.Agent Mode
Conversation: https://staging.warp.dev/conversation/bf2bfec5-b6f8-4029-a68d-437f1eff95ce
Run: https://oz.staging.warp.dev/runs/019ff234-cd04-72ac-9d0b-817fe25ac484
This PR was generated with Oz.