Skip to content

Consolidate TuiCostTransparency into PricingTransparency feature flag - #14939

Open
Xavientois wants to merge 3 commits into
masterfrom
saga/pricing-transparency-m1-20260810-2203/m1t7-pricing-transparency-client-flag
Open

Consolidate TuiCostTransparency into PricingTransparency feature flag#14939
Xavientois wants to merge 3 commits into
masterfrom
saga/pricing-transparency-m1-20260810-2203/m1t7-pricing-transparency-client-flag

Conversation

@Xavientois

@Xavientois Xavientois commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

Adds and consolidates the client-side PricingTransparency feature flag, replacing the old TuiCostTransparency flag entirely.

  • Added FeatureFlag::PricingTransparency (mirrors the server-side PricingTransparencyEnabled flag in warp-server PR feat: surface resolved model + router config link in warping indicator (APP-4978) #14283, but is a fully independent mechanism — the two don't sync automatically).
  • Replaced every FeatureFlag::TuiCostTransparency reference (in crates/warp_tui/src/usage.rs, usage_tests.rs, terminal_session_view_tests.rs) with FeatureFlag::PricingTransparency.
  • Removed the old TuiCostTransparency variant and its DOGFOOD_FLAGS entry.
  • Added PricingTransparency to DOGFOOD_FLAGS (on by default for the dev team). Not in PREVIEW_FLAGS/RELEASE_FLAGS; no flag_description() entry since that list is reserved for PREVIEW_FLAGS members.
  • No behavior change: PricingTransparency was already effectively equivalent to the old flag's dogfood/staging enablement, so the TUI credits⇄dollars toggle behaves identically. This flag will also gate the not-yet-built GUI footer dollar display.

Note: this repo's base branch is master (no develop branch exists here).

Linked Issue

  • N/A — part of an internal pricing-transparency saga (client-side flag consolidation).

Testing

  • cargo check -p warp_features -p warp_tui — passes
  • cargo test -p warp_tui (usage + terminal_session_view suites) — all pass, including the renamed-flag test paths
  • cargo fmt -p warp_features -p warp_tui -- --check / cargo clippy -p warp_features -p warp_tui --all-targets --all-features -- -D warnings — clean
  • git diff origin/master --stat: crates/warp_features/src/lib.rs, crates/warp_tui/src/{usage.rs,usage_tests.rs,terminal_session_view_tests.rs}

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Co-Authored-By: Warp Agent agent@warp.dev

Adds a PricingTransparency variant to the FeatureFlag enum, mirroring
the server-side PricingTransparencyEnabled flag (warp-server PR
#14283). Scaffolding only: not added to DOGFOOD_FLAGS, PREVIEW_FLAGS,
or RELEASE_FLAGS, and not consumed anywhere yet. Display work is
paused Milestone 3.

Co-Authored-By: Warp Agent <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Aug 11, 2026
Add FeatureFlag::PricingTransparency to DOGFOOD_FLAGS so it's on by
default for the development team. Not added to PREVIEW_FLAGS or
RELEASE_FLAGS, and no flag_description() entry -- that list is
reserved for PREVIEW_FLAGS members only (per the doc comment on
flag_description), and this flag isn't in PREVIEW_FLAGS.

Co-Authored-By: Warp Agent <agent@warp.dev>
@Xavientois
Xavientois requested a review from jefflloyd August 11, 2026 15:32
@Xavientois
Xavientois marked this pull request as ready for review August 11, 2026 15:32
@oz-for-oss

oz-for-oss Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@Xavientois

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

Adds the client-side FeatureFlag::PricingTransparency scaffold and enables it for Dogfood builds. There are no call sites yet, so this does not currently change user-visible behavior.

Concerns

  • No blocking concerns found.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Replace every FeatureFlag::TuiCostTransparency reference with
FeatureFlag::PricingTransparency and remove the old flag entirely
(enum variant + DOGFOOD_FLAGS entry). PricingTransparency now covers
the TUI credits<->dollars toggle that TuiCostTransparency used to
gate, plus the still-unbuilt GUI footer display.

No behavior change: PricingTransparency was already in DOGFOOD_FLAGS,
so dogfood/staging + local/dev builds keep the toggle enabled exactly
as before; prod/stable stays disabled.

Co-Authored-By: Warp Agent <agent@warp.dev>
@Xavientois Xavientois changed the title Add client-side PricingTransparency feature flag scaffolding Consolidate TuiCostTransparency into PricingTransparency feature flag Aug 11, 2026
@Xavientois
Xavientois enabled auto-merge (squash) August 11, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant