Consolidate TuiCostTransparency into PricingTransparency feature flag - #14939
Open
Xavientois wants to merge 3 commits into
Open
Conversation
Adds a PricingTransparency variant to the FeatureFlag enum, mirroring the server-side PricingTransparencyEnabled flag (warp-server PR #14283). Scaffolding only: not added to DOGFOOD_FLAGS, PREVIEW_FLAGS, or RELEASE_FLAGS, and not consumed anywhere yet. Display work is paused Milestone 3. Co-Authored-By: Warp Agent <agent@warp.dev>
Add FeatureFlag::PricingTransparency to DOGFOOD_FLAGS so it's on by default for the development team. Not added to PREVIEW_FLAGS or RELEASE_FLAGS, and no flag_description() entry -- that list is reserved for PREVIEW_FLAGS members only (per the doc comment on flag_description), and this flag isn't in PREVIEW_FLAGS. Co-Authored-By: Warp Agent <agent@warp.dev>
Xavientois
marked this pull request as ready for review
August 11, 2026 15:32
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
Adds the client-side FeatureFlag::PricingTransparency scaffold and enables it for Dogfood builds. There are no call sites yet, so this does not currently change user-visible behavior.
Concerns
- No blocking concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Replace every FeatureFlag::TuiCostTransparency reference with FeatureFlag::PricingTransparency and remove the old flag entirely (enum variant + DOGFOOD_FLAGS entry). PricingTransparency now covers the TUI credits<->dollars toggle that TuiCostTransparency used to gate, plus the still-unbuilt GUI footer display. No behavior change: PricingTransparency was already in DOGFOOD_FLAGS, so dogfood/staging + local/dev builds keep the toggle enabled exactly as before; prod/stable stays disabled. Co-Authored-By: Warp Agent <agent@warp.dev>
Xavientois
enabled auto-merge (squash)
August 11, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds and consolidates the client-side
PricingTransparencyfeature flag, replacing the oldTuiCostTransparencyflag entirely.FeatureFlag::PricingTransparency(mirrors the server-sidePricingTransparencyEnabledflag in warp-server PR feat: surface resolved model + router config link in warping indicator (APP-4978) #14283, but is a fully independent mechanism — the two don't sync automatically).FeatureFlag::TuiCostTransparencyreference (incrates/warp_tui/src/usage.rs,usage_tests.rs,terminal_session_view_tests.rs) withFeatureFlag::PricingTransparency.TuiCostTransparencyvariant and itsDOGFOOD_FLAGSentry.PricingTransparencytoDOGFOOD_FLAGS(on by default for the dev team). Not inPREVIEW_FLAGS/RELEASE_FLAGS; noflag_description()entry since that list is reserved forPREVIEW_FLAGSmembers.PricingTransparencywas already effectively equivalent to the old flag's dogfood/staging enablement, so the TUI credits⇄dollars toggle behaves identically. This flag will also gate the not-yet-built GUI footer dollar display.Note: this repo's base branch is
master(nodevelopbranch exists here).Linked Issue
Testing
cargo check -p warp_features -p warp_tui— passescargo test -p warp_tui(usage + terminal_session_view suites) — all pass, including the renamed-flag test pathscargo fmt -p warp_features -p warp_tui -- --check/cargo clippy -p warp_features -p warp_tui --all-targets --all-features -- -D warnings— cleangit diff origin/master --stat:crates/warp_features/src/lib.rs,crates/warp_tui/src/{usage.rs,usage_tests.rs,terminal_session_view_tests.rs}Agent Mode
Co-Authored-By: Warp Agent agent@warp.dev