Skip to content

Fix char-boundary panic in WorkflowDataSource preview truncation (APP-5287) #14933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vorporeal merged 3 commits into from
Aug 12, 2026
+7 −1
Merged

Fix char-boundary panic in WorkflowDataSource preview truncation (APP-5287) #14933

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e83eed7
Fix char-boundary panic in WorkflowDataSource preview truncation
oz-agent Aug 11, 2026
7b4e632
Pin exact truncated output in workflow data source regression tests
oz-agent Aug 11, 2026
6d3a638
Remove regression test per reviewer request
oz-agent Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/search/ai_context_menu/workflows/data_source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use super::search_item::WorkflowSearchItem;
use crate::cloud_object::CloudModelType;
use crate::cloud_object::model::persistence::CloudModel;
use crate::search::ai_context_menu::mixer::AIContextMenuSearchableAction;
use crate::search::ai_context_menu::safe_truncate;
use crate::search::data_source::{Query, QueryResult};
use crate::search::mixer::{DataSourceRunErrorWrapper, SyncDataSource};
use crate::workspaces::user_workspaces::UserWorkspaces;
Expand Down Expand Up @@ -66,7 +67,12 @@ impl SyncDataSource for WorkflowDataSource {
None
} else {
Some(if content_preview.len() > 200 {
format!("{}...", &content_preview[..197])
// Truncate at a valid UTF-8 char boundary to avoid panicking when a
// multi-byte character straddles the byte-197 cut point.
let mut truncated = content_preview;
safe_truncate(&mut truncated, 197);
truncated.push_str("...");
truncated
} else {
content_preview
})
Expand Down
Loading