review-pr-local: mark comment/testing guideline violations as IMPORTANT - #14907
Merged
Conversation
Move the AGENTS.md comment audit out of the general pattern list into its own mandatory, rule-by-rule checklist step, and cross-reference rust-unit-tests's "test through the public API" rule specifically for regression tests. Also add a short Regression Test Adequacy note to rust-unit-tests. QUALITY-1563 Co-Authored-By: Warp Agent <agent@warp.dev>
…erfactual Match the core skill's strengthened regression-test-adequacy wording: require naming the assertion that would fail if the exact buggy code reappeared at its real call site, not just that the test executes that call site. QUALITY-1563 Co-Authored-By: Warp Agent <agent@warp.dev>
Per requester feedback, scale back the warp-side change: revert rust-unit-tests/SKILL.md entirely, and revert review-pr-local's mandatory comment-audit section and testing cross-reference back to master (leaving #14902's existing comment-audit bullet untouched). Add only a short clause to the existing testing bullet and the existing commenting bullet under 'Repo-specific style and recurring review patterns' noting that confirmed violations should be treated as IMPORTANT, not a nit. QUALITY-1563 Co-Authored-By: Warp Agent <agent@warp.dev>
warp-agent-staging
Bot
changed the title
acarl005
approved these changes
Aug 11, 2026
acarl005
marked this pull request as ready for review
August 11, 2026 01:05
acarl005
marked this pull request as ready for review
August 11, 2026 01:17
acarl005
enabled auto-merge (squash)
August 11, 2026 01:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to warpdotdev/common-skills#50. A minimal, repo-specific addition to
.agents/skills/review-pr-local/SKILL.md: two short clauses appended to the existing testing bullet and the existing commenting bullet (the latter added by #14902) under## Repo-specific style and recurring review patterns, noting that a confirmed violation of either should be treated as⚠️ [IMPORTANT], not a nit. Nothing else changed — no new sections, no changes to.agents/skills/rust-unit-tests/SKILL.md, and #14902's original comment-audit bullet is otherwise untouched.git diff origin/master --stat: 1 file changed, 2 insertions(+), 2 deletions(-).Prompted by two real issues that slipped through a
review-pr+review-pr-localpass on PR #13405: a transformation-comment violation inapp/src/util/windows.rs(plus otherAGENTS.mdcomment issues), and a "regression test" inapp/src/system/info_tests.rsthat only exercised a private helper instead of the call site where the historical bug lived.Linear: QUALITY-1563
Linked Issue
Testing
Doc-only change — no code changed, so no automated/manual app testing applies.
Validated together with warpdotdev/common-skills#50's specialization-contract repair via fresh subagents with no prior knowledge of the expected findings, run repeatedly with no scripted loading of this companion skill (each reviewer had to discover it on its own). Result across 3 final independent runs: the companion was discovered unprompted in all 3, confirming the core-skill specialization mechanism works; of the three original PR #13405 findings, the transformation-comment violation surfaced in 2 of 3 runs (⚠️ IMPORTANT), while the redundant/duplicated comment and the regression-test call-site gap did not surface in any of the 3 runs at this final state. The regression-test gap specifically has no corresponding content anywhere in this file or in
rust-unit-tests/SKILL.mdright now, so it isn't expected to surface until/unless that content is added here — see warpdotdev/common-skills#50's description for the full tallies, verbatimreview.json, and validator output.Screenshots / Videos
N/A — skill documentation change only.
Agent Mode
Conversation: https://staging.warp.dev/conversation/ed29a745-bc15-4653-8e60-7ae1d25ec9da
Run: https://oz.staging.warp.dev/runs/019fedeb-6452-7cb8-b1a5-08c41f3f37c6
This PR was generated with Oz.