fix(translator): drop invalid reasoning signatures in interactions→Responses - #4
Merged
warelik merged 1 commit intoAug 22, 2026
Conversation
…sponses Interactions thought signatures can come from non-GPT providers (Gemini thoughtSignature, Claude signature, etc.). When translating an interactions stream into OpenAI Responses, only a valid GPT/Codex reasoning encrypted_content should appear in the reasoning item. Foreign signatures are now filtered through InspectGPTReasoningSignature. Tests updated: valid gAAAA signature is preserved, invalid foreign signature is dropped.
warelik
force-pushed
the
ao/airouters-17-gpt-codex-reasoning
branch
from
August 22, 2026 05:01
9552176 to
119b955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thoughtSignature,signature,encrypted_contentfrom non-GPT providers) intoreasoning.encrypted_contentwithout validation.encrypted_contentcan round-trip through Responses reasoning items.interactionsReasoningEncryptedContentvalidates the candidate withsignature.InspectGPTReasoningSignatureand drops invalid/foreign blobs while preserving the visiblesummary.gAAAA...GPT signature is preserved; invalid foreign signature is dropped.Cross-links
Verification
go build -o /tmp/cli-proxy-api ./cmd/servergo test ./...(7686 passed)go test ./internal/translator/openai/interactions/responses/