feat(v3): add noprivateapis macOS build variant - #5955
Draft
taliesin-ai wants to merge 3 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
27 tasks
…-api-opt-in # Conflicts: # v3/UNRELEASED_CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noprivateapisbuild tag that selects public WebKit and AppKit implementations without changing the Go APIPublic-only build
The public-only variant degrades safely: transparent and full-window glass backdrops remain configured behind an opaque WKWebView, cross-window glass grouping is ignored, native styles map to public regular/clear styles, automatic inspector opening becomes a no-op, and manual Safari inspection remains available on macOS 13.3+.
Validation
go test ./pkg/applicationpassed before synchronising currentmastergo test -tags noprivateapis ./pkg/application -run 'TestMacPrivateAPIBuildVariantsAreExclusive|TestPrivateMacAPIReferencesStayOutOfNoPrivateAPIFiles' -count=1noprivateapisDarwin file selection verified withgo listgit diff --checkAfter merging current
master, the broader package run is blocked only by the existing environment-sensitiveTestX11GlobalShortcutEndToEnd: its synthesised X11 keypress does not fire a callback in this desktop environment. The macOS build-variant tests remain green.