Cleanly split single-epoch and multi-epoch attribution handling#461
Draft
apasel422 wants to merge 3 commits into
Draft
Cleanly split single-epoch and multi-epoch attribution handling#461apasel422 wants to merge 3 commits into
apasel422 wants to merge 3 commits into
Conversation
The "deduct privacy and safety budgets" algorithm is invoked exactly once per epoch in the chosen range, so it is unconditionally true that each epoch's global budget is deducted from at most once.
A given impression belongs to a single epoch, and the "deduct privacy and safety budgets" algorithm is invoked exactly once per epoch in the chosen range, so there is no need to maintain a set keyed by epoch across invocations of that algorithm.
This makes it clear that the L1 norm computation is irrelevant for the latter, and inherently avoids the redundant common matching logic and histogram creation for the former.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it clear that the L1 norm computation is irrelevant for the latter, and inherently avoids the redundant common matching logic and histogram creation for the former.
Fixes #397.
Preview | Diff