Skip to content

fix: reject failed attachment downloads#1

Merged
vycdev merged 1 commit into
vycdev:mainfrom
vycdev2:fix/attachment-http-errors
Jul 23, 2026
Merged

fix: reject failed attachment downloads#1
vycdev merged 1 commit into
vycdev:mainfrom
vycdev2:fix/attachment-http-errors

Conversation

@vycdev2

@vycdev2 vycdev2 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • reject non-successful HTTP responses before saving Discord attachment bodies
  • surface the HTTP status through existing caller error handling instead of returning a path to an invalid image

Verification

  • npm run build — passed (tsc)
  • local HTTP behavior check — passed: HTTP 404 rejected without writing a file; HTTP 200 still saved the response body
  • git diff --check — passed

Risk

  • Low: the change only converts non-2xx attachment responses from false successes into errors already handled by callers.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev
vycdev merged commit e42041c into vycdev:main Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants