Skip to content

fix: downgrade default edition #9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joseph-isaacs wants to merge 1 commit into from
Closed

fix: downgrade default edition #9473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vortex/src/editions/core/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ pub use v2025_05::CORE_2025_05_0;
pub use v2025_06::CORE_2025_06_0;
pub use v2025_10::CORE_2025_10_0;
pub use v2026_07::CORE_2026_07_0;
pub use v2026_08::CORE_2026_08;
pub use v2026_08::CORE_2026_08_0;
2 changes: 1 addition & 1 deletion vortex/src/editions/core/v2026_07.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pub const CORE_2026_07_0: EditionId = EditionId::new("core", 2026, 7, 0);
pub static DECLARATION: EditionDeclaration = EditionDeclaration {
edition: Edition {
id: CORE_2026_07_0,
min_vortex_version: Some("0.65.0"),
min_vortex_version: None,
},
added: &[EditionMember::array(&"vortex.variant")],
};
8 changes: 4 additions & 4 deletions vortex/src/editions/core/v2026_08.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ use vortex_edition::EditionId;
use vortex_edition::EditionMember;

/// The August 2026 core edition containing canonical Map arrays.
pub const CORE_2026_08: EditionId = EditionId::new("core", 2026, 8, 0);
pub const CORE_2026_08_0: EditionId = EditionId::new("core", 2026, 8, 0);

/// The declaration of [`CORE_2026_08`] and the components that join the family at it.
/// The declaration of [`CORE_2026_08_0`] and the components that join the family at it.
///
/// The aggregates are the set the default writer records in zone maps. Declaring them arms the
/// writer's aggregate filter, so a strategy asking for an aggregate outside this set fails the
Expand All @@ -22,8 +22,8 @@ pub const CORE_2026_08: EditionId = EditionId::new("core", 2026, 8, 0);
/// records it, so the two stay consistent.
pub static DECLARATION: EditionDeclaration = EditionDeclaration {
edition: Edition {
id: CORE_2026_08,
min_vortex_version: Some("0.84.0"),
id: CORE_2026_08_0,
min_vortex_version: None,
},
added: &[
EditionMember::array(&"vortex.map"),
Expand Down
6 changes: 3 additions & 3 deletions vortex/src/editions/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
//! it, and a component outside the enabled editions fails the write whatever its kind.
//!
//! The default file writer resolves the session's enabled editions at write time. The
//! facade enables the newest frozen `core` edition, [`crate::editions::CORE_2026_08`], and
//! facade enables the newest frozen `core` edition, [`crate::editions::CORE_2026_08_0`], and
//! additionally enables the latest unstable edition when the `unstable_encodings` feature is
//! selected.

Expand All @@ -39,14 +39,14 @@ pub use self::core::CORE_2025_05_0;
pub use self::core::CORE_2025_06_0;
pub use self::core::CORE_2025_10_0;
pub use self::core::CORE_2026_07_0;
pub use self::core::CORE_2026_08;
pub use self::core::CORE_2026_08_0;
pub use self::unstable::UNSTABLE_2025_05_0;
pub use self::unstable::UNSTABLE_2026_02_0;
pub use self::unstable::UNSTABLE_2026_04_0;
pub use self::unstable::UNSTABLE_2026_06_0;

/// The `core` edition enabled for writing by the default Vortex session.
pub const DEFAULT_CORE_EDITION: EditionId = CORE_2026_08;
pub const DEFAULT_CORE_EDITION: EditionId = CORE_2025_10_0;

/// The `unstable` edition enabled for writing by the default Vortex session when the
/// `unstable_encodings` feature is selected.
Expand Down
8 changes: 4 additions & 4 deletions vortex/src/editions/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ use vortex_utils::aliases::hash_set::HashSet;

use super::CORE_2025_05_0;
use super::CORE_2026_07_0;
use super::CORE_2026_08;
use super::CORE_2026_08_0;
use super::DEFAULT_CORE_EDITION;
use super::DEFAULT_UNSTABLE_EDITION;
use super::EDITION_DECLARATIONS;
Expand Down Expand Up @@ -145,7 +145,7 @@ fn encodings_in_editions_unions_families() {
fn earlier_editions_are_subsets() {
let session = session().unwrap_or_else(|e| panic!("registering editions: {e}"));
let first = session.components_in(&CORE_2025_05_0, ComponentKind::Array);
let latest = session.components_in(&CORE_2026_08, ComponentKind::Array);
let latest = session.components_in(&CORE_2026_08_0, ComponentKind::Array);
assert!(first.iter().all(|inclusion| {
latest
.iter()
Expand Down Expand Up @@ -178,7 +178,7 @@ fn core_edition_ids_are_registered_array_encodings() {
let registry = session.arrays().registry().clone();
for inclusion in session
.editions()
.components_in(&CORE_2026_08, ComponentKind::Array)
.components_in(&CORE_2026_08_0, ComponentKind::Array)
{
assert!(
registry.contains_key(&inclusion.component_id),
Expand All @@ -199,7 +199,7 @@ fn core_aggregate_ids_are_registered_aggregate_fns() {
let session = VortexSession::default();
let declared = session
.editions()
.components_in(&CORE_2026_08, ComponentKind::Aggregate);
.components_in(&CORE_2026_08_0, ComponentKind::Aggregate);
assert!(
declared
.iter()
Expand Down
Loading