Skip to content

Deduplicate BitBuffer set-index visitors - #9461

Merged
connortsui20 merged 1 commit into
developfrom
ct/bit-buffer-infallible-visitor
Aug 18, 2026
Merged

Deduplicate BitBuffer set-index visitors#9461
connortsui20 merged 1 commit into
developfrom
ct/bit-buffer-infallible-visitor

Deduplicate BitBuffer set-index visitors

d67c41c
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Aug 18, 2026 in 0s

Performance Regression: -10.88%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 1 regressed benchmark
✅ 1999 untouched benchmarks
🆕 4 new benchmarks
⏩ 89 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_canonicalize_into[(1000, 50, 8, 64)] 15.1 ms 16.9 ms -10.88%
🆕 Simulation all_valid_exclusive[4096] N/A 482.6 µs N/A
🆕 Simulation all_valid_exclusive[65536] N/A 7.3 ms N/A
🆕 Simulation nullable_exclusive[4096] N/A 358.7 µs N/A
🆕 Simulation nullable_exclusive[65536] N/A 5.2 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/bit-buffer-infallible-visitor (d67c41c) with develop (bf6b2be)2

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (004e512) during the generation of this report, so bf6b2be was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.