Enable OnPair in GPU compression benchmark - #9455
Draft
joseph-isaacs wants to merge 1 commit into
Draft
Conversation
Signed-off-by: "Robert Kruszewski" <github@robertk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GPU compression workflow and documented local command already build with
cuda,unstable_encodings; this makes the CUDA-compatible compressor actually consider OnPair under that feature set.Local evidence
Command:
String-heavy
TPC-H l_comment canonical, based on mergeddevelopafter #8920:I removed the old capture and regenerated
/tmp/onpair-gpu-decompress.vortexfrom this branch. The new file is a valid 222,367,880-byte VTXF file (SHA-2560bb262282ff5c3fcd3459141cffbc01f6f465c7287221f29d4ffa4853cb396e3). A fresh-file runtime trace confirms actual use, rather than only registry presence:Checks
cargo +nightly fmt --all -- --checkcargo test -p vortex-btrblocks --features unstable_encodings builder::tests::cuda_compatible_uses_gpu_string_encodingscargo test -p vortex-cuda onpair -- --nocapture(19 passed)cargo clippy -p vortex-compressor -p vortex-btrblocks -p vortex-cuda --all-targets --all-features