Skip to content

GPU: remove FSST metadata upload callbacks #9430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joseph-isaacs wants to merge 1 commit into
base: joe/gpu-fsst-device-output
Choose a base branch
from
Draft

GPU: remove FSST metadata upload callbacks #9430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions vortex-cuda/src/kernel/encodings/fsst.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,10 @@ where
} = codes_offsets.into_data_parts();
let (validity_bit_offset, validity_bits) = cuda_validity(&validity, num_strings, ctx).await?;

let (symbols, symbol_lengths, validity_device, codes_bytes, codes_offsets) = futures::try_join!(
ctx.copy_to_device(symbols_u64)?,
ctx.copy_to_device(symbol_lengths)?,
ctx.ensure_on_device(validity_bits),
let symbols = ctx.stream().copy_to_device_sync(&symbols_u64)?;
let symbol_lengths = ctx.stream().copy_to_device_sync(symbol_lengths.as_ref())?;
let validity_device = ctx.ensure_on_device_sync(validity_bits)?;
let (codes_bytes, codes_offsets) = futures::try_join!(
ctx.ensure_on_device(codes_bytes_handle),
ctx.ensure_on_device(codes_offsets_buffer),
)?;
Expand Down Expand Up @@ -305,10 +305,10 @@ where
} = codes_offsets.into_data_parts();
let (validity_bit_offset, validity_bits) = cuda_validity(&validity, len, ctx).await?;

let (symbols, symbol_lengths, validity_device, codes_bytes, codes_offsets) = futures::try_join!(
ctx.copy_to_device(symbols_u64)?,
ctx.copy_to_device(symbol_lengths)?,
ctx.ensure_on_device(validity_bits),
let symbols = ctx.stream().copy_to_device_sync(&symbols_u64)?;
let symbol_lengths = ctx.stream().copy_to_device_sync(symbol_lengths.as_ref())?;
let validity_device = ctx.ensure_on_device_sync(validity_bits)?;
let (codes_bytes, codes_offsets) = futures::try_join!(
ctx.ensure_on_device(codes_bytes_handle),
ctx.ensure_on_device(codes_offsets_buffer),
)?;
Expand Down
Loading