Skip to content

Fix VM publish E2E test by waiting for disk promotion - #1822

Open
anwithaun-1 wants to merge 7 commits into
vmware-tanzu:mainfrom
anwithaun-1:topic/anwitha/fix-vm-publishrequest-flaky-test
Open

Fix VM publish E2E test by waiting for disk promotion#1822
anwithaun-1 wants to merge 7 commits into
vmware-tanzu:mainfrom
anwithaun-1:topic/anwitha/fix-vm-publishrequest-flaky-test

Conversation

@anwithaun-1

@anwithaun-1 anwithaun-1 commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do, and why is it needed?
Fixes a flake in the VirtualMachinePublishRequest E2E spec should preserve vAppConfig properties on a VM deployed from the published image, which timed out after waiting for Complete=True.

• [FAILED] [583.156 seconds]
Testing VM Services VIRTUAL-MACHINE VM-PUBLISH-REQUEST VirtualMachinePublishRequest CLS Content Library [It] should preserve vAppConfig properties on a VM deployed from the published image [devops, viadmin, virtualmachine, vmservice, extended-functional, experimental]
/vm-operator/test/e2e/vmservice/vmservice/virtualmachine/vm_publishrequest.go:305

  [FAILED] Timed out after 360.003s.
  Timed out waiting for Condition: {Type:Complete Status:True ObservedGeneration:0 LastTransitionTime:0001-01-01 00:00:00 +0000 UTC Reason: Message:} on VirtualMachinePublishRequest: vm-publish-ouoa-vapp
  The function passed to Eventually failed at /vm-operator/test/e2e/vmservice/lib/vmoperator/vmoperator.go:695 with:
  Expected
      <v1.ConditionStatus>: False
  to equal
      <v1.ConditionStatus>: True
  In [It] at: /vm-operator/test/e2e/vmservice/lib/vmoperator/vmoperator.go:700 @ 08/13/26 20:37:22.703

What does this PR do, and why is it needed?

  • The VirtualMachinePublishRequest spec should preserve vAppConfig properties on a VM deployed from the published image intermittently times out waiting for Complete=True
  • This is a race with VM Operator's background disk promotion, not a product defect. The spec creates its own source VM as a Fast Deploy linked clone and publishes it ~3 minutes later — while PromoteDisks_Task is still running. vCenter serializes the OVF capture behind that task, so Uploaded stays Queued/Uploading and Complete never flips inside the spec's 6m budget. The neighbouring smoke publish spec is unaffected because it publishes the long-lived suite VM, whose promotion finished ~50 minutes earlier.

Fix:

  • Deploy the source VM in Fast Deploy direct mode via the vmoperator.vmware.com/fast-deploy annotation. Direct mode copies disks into the VM directory instead of creating a linked clone, so there are no delta disks, no promotion task, and nothing competing with the capture.
  • This doesn't weaken the spec — publish has no dependency on disk promotion. the publish path has zero references to promotion. The spec asserts that a vApp property set via bootstrap.vAppConfig survives publish and reappears on a VM deployed from the published image, and vApp properties live in config.vAppConfig, captured into the OVF envelope — disk provenance is irrelevant to it.

Also re-adds experimental to the spec's labels, since it is being changed and has not been validated on hardware in this form.

Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes # vmop-4048

Are there any special notes for your reviewer:

Please add a release note if necessary:

@github-actions github-actions Bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 14, 2026
@anwithaun-1
anwithaun-1 force-pushed the topic/anwitha/fix-vm-publishrequest-flaky-test branch from 380bc68 to 3b5caf7 Compare August 17, 2026 05:33
@anwithaun-1 anwithaun-1 changed the title fix vm publishrequest failure Fix VM publish E2E test by waiting for disk promotion Aug 17, 2026
@anwithaun-1
anwithaun-1 marked this pull request as ready for review August 17, 2026 05:35
@anwithaun-1
anwithaun-1 requested review from a team and faisalabujabal as code owners August 17, 2026 05:35
@anwithaun-1
anwithaun-1 requested a review from aakashchan August 17, 2026 06:54
aakashchan
aakashchan reviewed Aug 18, 2026
View reviewed changes
Comment thread test/e2e/vmservice/config/wcp.yaml Outdated
aakashchan
aakashchan reviewed Aug 18, 2026
View reviewed changes
Comment thread test/e2e/vmservice/lib/vmoperator/vmoperator.go Outdated
@github-actions github-actions Bot added size/S Denotes a PR that changes 10-29 lines. size/XS Denotes a PR that changes 0-9 lines. and removed size/M Denotes a PR that changes 30-99 lines. size/S Denotes a PR that changes 10-29 lines. labels Aug 19, 2026
@anwithaun-1
anwithaun-1 force-pushed the topic/anwitha/fix-vm-publishrequest-flaky-test branch from c050857 to a72a25c Compare August 19, 2026 16:08
@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Aug 19, 2026
@github-actions github-actions Bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Aug 19, 2026
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/controllers/configtarget 74% ❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem 67% ❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem 67% ❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils 85% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/configmap 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/crd 100% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap 75% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/node 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/secret 76% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/validatingwebhookconfiguration 87% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/workloadnetworkconfig 86% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/zone 80% ➖
github.com/vmware-tanzu/vm-operator/controllers/storage/storageclass 93% ✔
github.com/vmware-tanzu/vm-operator/controllers/storage/storagepolicy 96% ✔
github.com/vmware-tanzu/vm-operator/controllers/storage/storagepolicyquota 91% ✔
github.com/vmware-tanzu/vm-operator/controllers/storage/volumeattributesclass 93% ✔
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/storagepolicyusage 96% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/virtualmachine 65% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volume 85% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volumebatch 89% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineconfigoptions 87% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinegroup 90% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinegrouppublishrequest 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineimagecache 89% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest 84% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinereplicaset 67% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice 91% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers 93% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy 81% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesnapshot 91% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch 78% ❌
github.com/vmware-tanzu/vm-operator/controllers/vspherepolicy/policyevaluation 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/bitmask 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/builder 89% ➖
github.com/vmware-tanzu/vm-operator/pkg/conditions 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/config 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/capabilities 97% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/env 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/context 37% ❌
github.com/vmware-tanzu/vm-operator/pkg/context/generic 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/context/operation 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/crd 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/errors 74% ❌
github.com/vmware-tanzu/vm-operator/pkg/exit 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/log 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/mem 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/prober 89% ➖
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere 74% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules 73% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network 83% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement 70% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session 60% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/storage 44% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/upgrade/virtualmachine 96% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/upgrade/virtualmachine/backfill 96% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter 86% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine/extraconfig 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine/networkextraconfig 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle 79% ❌
github.com/vmware-tanzu/vm-operator/pkg/record 84% ➖
github.com/vmware-tanzu/vm-operator/pkg/topology 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util 79% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/image 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/cource 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/internal 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/networksettings 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/proxyaddr 73% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/kube/spq 99% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/linuxprep 97% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/netplan 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/nil 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache/internal 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/paused 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/ptr 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/resize 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/sysprep 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/volumes 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client 66% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/datastore 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/fault 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/library 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/storage 82% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/task 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/watcher 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/anno2extraconfig 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/bootoptions 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/cdrom 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/crypto 92% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/diskpromo 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/extraconfig 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/networkextraconfig 79% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/policy 97% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/virtualcontroller 93% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/volumes/unmanaged/backfill 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/volumes/unmanaged/register 92% ✔
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 100% ✔
github.com/vmware-tanzu/vm-operator/services/vm-watcher 85% ➖
github.com/vmware-tanzu/vm-operator/webhooks/common 98% ✔
github.com/vmware-tanzu/vm-operator/webhooks/configtarget/validation 87% ➖
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/unifiedstoragequota/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation 86% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation 96% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation 62% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation 89% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineconfigoptions/validation 88% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegroup/mutation 87% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegroup/validation 93% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegrouppublishrequest/mutation 86% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegrouppublishrequest/validation 88% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineguestoptions/validation 88% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation 90% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation 90% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation 67% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesnapshot/mutation 86% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesnapshot/validation 91% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/validation 92% ✔
Summary 84% (21713 / 25706) ➖

Minimum allowed line rate is 79%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aakashchan aakashchan aakashchan left review comments
@faisalabujabal faisalabujabal Awaiting requested review from faisalabujabal faisalabujabal is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anwithaun-1 @aakashchan