✨ Tag Controller for Assignment of Tags to VMs - #1807
Open
aniket-deole wants to merge 1 commit into
Open
Conversation
aniket-deole
force-pushed
the
aniketd/tag-controller-changes
branch
from
August 14, 2026 07:18
73befc8 to
f1b293a
Compare
aniket-deole
added
the
ai-review-requested
aniket-deole
force-pushed
the
aniketd/tag-controller-changes
branch
2 times, most recently
from
August 17, 2026 18:17
d3bf323 to
1bb601c
Compare
aniket-deole
marked this pull request as ready for review
August 17, 2026 21:50
|
📝 CL Summary: This PR introduces a new namespace-scoped |
|
|
||
| vCenter Tags are identified by name **and** category, and are unique across that combination. Every vCenter Tag backing this feature uses the **namespace name** as its Tag Category, derived from the `Tag`'s own namespace — the category is not a separate user-settable field. | ||
|
|
||
| Attributes: |
There was a problem hiding this comment.
🟡 Medium: The use of 'ownerReferences' for Tag ownership may hit Kubernetes object size limits (1.5MB) in namespaces with a very large number of VMs (thousands) referencing the same common label (e.g., 'env=prod'). Each reference consumes metadata space; consider a more scalable ownership tracking mechanism if high-density namespaces are a target use case.
svc-vmop-bot
added
the
ai-reviewed
faisalabujabal
removed
the
ai-review-requested
aniket-deole
force-pushed
the
aniketd/tag-controller-changes
branch
from
August 18, 2026 05:24
1bb601c to
8f85dd3
Compare
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Introduces a new namespace-scoped Tag CRD (vsphere.policy.vmware.com/v1alpha1) and a Tag controller to drive vCenter Tag-based VM affinity/anti-affinity. Today, labels are only converted to vCenter Tags for a VM that itself declares spec.affinity referencing them, and only at create time — so a VM carrying a participating label but no affinity of its own is never tagged and can't be targeted by another VM's affinity rule.
This change tracks which label key/value pairs currently participate in affinity and which VMs own that participation, then tags every VM in the namespace carrying a participating label (not just affinity-declaring VMs), re-converging on every reconcile rather than only at create.
This PR is part of a 4 part change
This PR includes:
Other parts:
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: