Introduce pkg/sdk go.mod and VPCNetworkConfiguration function helpers - #68
Introduce pkg/sdk go.mod and VPCNetworkConfiguration function helpers#68ihgann wants to merge 2 commits into
Conversation
This change introduces a new go.mod for pkg/sdk to keep it isolated from the root go.mod and introduces VPCNetworkConfiguration function helpers related to NamespaceNetworkConfiguration in pkg/sdk.
yangna0420
left a comment
yangna0420
left a comment
There was a problem hiding this comment.
Thanks， I need replied on this changes on my VPC get
| require ( | ||
| github.com/stretchr/testify v1.11.1 | ||
| github.com/vmware-tanzu/net-operator-api v0.0.0 | ||
| github.com/vmware-tanzu/nsx-operator/pkg/apis v0.0.0-20260818083459-96cb17ddc8e0 |
There was a problem hiding this comment.
Hi Ian，Just curious about one question, github.com/vmware-tanzu/nsx-operator v0.0.0-20260604071952-21b82cc9119b this version is commonly used in our tera component, If the version v0.0.0-20260818083459-96cb17ddc8e0 is used now, will there be any risks? Do we need to keep all versions of tera side consistent?
There was a problem hiding this comment.
In fact, in my PR https://github-vcf.devops.broadcom.net/vcf/tera/pull/102721, I found that when the version changes, there are indeed some UT failures, so we need to make changes.
If decide use the new version. We might need to upgrade all the nsx-operator versions in tera together and do some UT fixes. However, that should be a separate PR. I don't want to introduce it into my PR
There was a problem hiding this comment.
Hi Ian，Just curious about one question, github.com/vmware-tanzu/nsx-operator v0.0.0-20260604071952-21b82cc9119b this version is commonly used in our tera component, If the version v0.0.0-20260818083459-96cb17ddc8e0 is used now, will there be any risks? Do we need to keep all versions of tera side consistent?
This is an APIs sub-component. It would be good to keep consistent, yes, but this is not a dangerous pull as it's just API types.
3 participants
This change introduces a new go.mod for pkg/sdk to keep it isolated from the root go.mod and introduces VPCNetworkConfiguration function helpers related to NamespaceNetworkConfiguration in pkg/sdk.
Testing Done:
make lint test