Add PreExistingNSXNetworkConfigAnnotation to support Net Operator adopting existing NSXNetworkConfigurations - #67
Open
ihgann wants to merge 4 commits into
Conversation
Add the constant that NamespaceNetworkConfiguration reacts to for adopting a pre-existing VPCNetworkConfiguration named ahead of the NNC, instead of always creating one named after the NNC itself. Needed for brownfield namespaces migrating from the legacy wcpsvc/VCDB path. Bug number: VKAL-40713 AI-Tool-Used: claude AI-Model-Used: claude-sonnet-5 AI-Tool-Use-Level: high AI-Code-Category: production AI-Time-Saved: 1 Testing Done: go build ./...
Mirrors PreExistingVPCNetworkConfigAnnotation (VKAL-40713) for the NSXTier1/NCP provider so an NNC can adopt a pre-existing NSXNetworkConfiguration CR instead of auto-creating one.
ihgann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Dependent on #62.
This change adds a new annotation,
netoperator.vmware.com/nsx-network-configuration, to indicate that when a NamespaceNetworkConfiguration is created with provider typensx-tier1and this annotation is set, theNSXNetworkConfigurationthat is referenced will be taken over ownership by the LCM controller of thisNamespaceNetworkConfiguration, instead of the default flow of constructing our own, new,NSXNetworkConfiguration.The intention of this is to handful brownfield cases where Net Operator should start to take ownership of network contracts, but previous Supervisors already maintain a
NSXNetworkConfigurationthat was previously LCM'd elsewhere.Constraints:
CREATEof theNamespaceNetworkConfiguration, when provider type isnsx-tier1.NamespaceNetworkConfigurationbecomes source-of-truth, and the spec of the associatedNSXNetworkConfigurationwill become reconciled to reflect the state of the existingNamespaceNetworkConfiguration.Validations will be managed in Net Operator.