fix: prevent panic in IsDSN on short input strings - #18
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsDSNguardss[:11]withlen(s) > 11but then evaluatess[:13]without a length check, so any non-DSN argument that is exactly 12 characters (for examplepgdesigner docs/apisrv.) panics withslice bounds out of range [:13] with length 12instead of being treated as a file path.This switches the two comparisons to
strings.HasPrefix, which does its own bounds checking and reads more clearly. Added a table-drivenTestIsDSNcovering both schemes and the short-string cases.Fixes #17