refactor(ui): make explorer tree dependencies explicit - #10942
Draft
hi-ogawa wants to merge 2 commits into
Draft
Conversation
Keep structural state ownership in ExplorerTree and pass explicit tree context to operation modules instead of importing the global singleton. Move direct result and timing mutations behind instance methods and remove the explorer state initialization cycle. Co-authored-by: OpenCode <noreply@opencode.ai>
Inject task and configuration access through one explorer operation context, move shared client refs to a cycle-free leaf module, and keep structural containers private to ExplorerTree. Co-authored-by: OpenCode <noreply@opencode.ai>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #issue-number
Pure refactoring of UI code to reduce singleton access and make data flow more explicit. Mostly mechanically done by agents. Not ready to land, but just seeing the diff like this already helps picturing the flow, so draft PR.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.