Skip to content

Align DELETE-with-body transport behavior with standard client path - #112

Open
Sokitha-21 wants to merge 5 commits into
vinyldns:masterfrom
Sokitha-21:delete_with_body_request
Open

Align DELETE-with-body transport behavior with standard client path#112
Sokitha-21 wants to merge 5 commits into
vinyldns:masterfrom
Sokitha-21:delete_with_body_request

Conversation

@Sokitha-21

@Sokitha-21 Sokitha-21 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Fixes: #109

Problem Statement
The previous implementation used two different execution paths:

  • Standard requests via AmazonHttpClient
  • DELETE-with-body via a custom Apache CloseableHttpClient
    Without explicit config parity, DELETE-with-body behavior could drift from the standard path (timeouts, retries, pooling, proxy, and connection lifecycle) causing inconsistent runtime behavior under load or network issues.

PR Changes

  • All requests, including DELETE-with-body continue to use the existing signer flow for request construction and signing.
  • The Apache CloseableHttpClient execution path is retained exclusively for DELETE requests with a payload as a necessary AWS SDK v1 compatibility workaround.
  • The Apache client is now explicitly configured to mirror ClientConfiguration settings from the standard AmazonHttpClient path: connect/socket/request timeouts, connection pooling, retry count, proxy credentials, connection TTL, idle eviction and disabled content compression.
  • Success/failure response mapping behavior is unchanged.

Testing and Validation
Unit tests pass with existing suite.
Manual verification performed against real endpoint for deleteZoneAclRule flow.
Confirmed signed DELETE-with-body requests execute successfully through custom path.

@snyk-io

snyk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@Sokitha-21 Sokitha-21 changed the title Delete with body request Align DELETE-with-body transport behavior with standard client path Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align the DELETE-with-body execution path with the standard AmazonHttpClient transport behavior

1 participant