upgrade to react 19 and tiptap editor#140
Open
bertyhell wants to merge 19 commits into
Open
Conversation
This reverts commit 5310f4b.
# Conflicts: # package-lock.json # package.json # src/components/Tooltip/Tooltip.tsx
… into feature/upgrade-react
reunefe
approved these changes
Jun 29, 2026
reunefe
left a comment
reunefe
left a comment
Contributor
There was a problem hiding this comment.
Op zich zie ik hier niet gigantisch veel problemen in. Wel veel any en niet vertaalbare labels 🙈
| }; | ||
|
|
||
| return cloneElement(children as ReactElement, { | ||
| return cloneElement(children as ReactElement<any>, { |
Contributor
There was a problem hiding this comment.
Waarom any ipv de juiste props interface?
|
|
||
| const isSingleElement = (node: ReactNode) => { | ||
| const el = node as JSX.Element; | ||
| const el = node as ReactElement<any>; |
Contributor
There was a problem hiding this comment.
Waarom any ipv de juiste props interface?
| import { DropdownButton, DropdownContent } from './Dropdown.slots'; | ||
|
|
||
| const DropdownStoryComponent = ({ children }: { children: ReactElement }) => { | ||
| const DropdownStoryComponent = ({ children }: { children: ReactElement<any> }) => { |
Contributor
There was a problem hiding this comment.
Waarom any ipv de juiste props interface?
| } | ||
|
|
||
| const renderSortingIndicator = (header: Header<RowDataType, unknown>) => { | ||
| if (!header.column.getCanSort()) return null; |
Contributor
There was a problem hiding this comment.
Ik vind dit heel moeilijk leesbaar met de oneliners
| aria-hidden={true} | ||
| className={clsx(thClass(false), focusedTdClass(false))} | ||
| > | ||
| <td role="presentation" className={clsx(thClass(false), focusedTdClass(false))}> |
Contributor
There was a problem hiding this comment.
Waarom heb je de aria-hidden eraf gehaald? Deze cel mag niet accessible zijn
| ))} | ||
| {group.headers.map((header) => { | ||
| const column = header.column; | ||
| const isSorted = column.getIsSorted() !== false; |
Contributor
There was a problem hiding this comment.
Ik zou dit eerder inverteren zodat je geen vals positief kan krijgen
Suggested change
| const isSorted = column.getIsSorted() !== false; | |
| const isSorted = column.getIsSorted() === true; |
| <> | ||
| <div | ||
| className="c-tooltip-component-trigger" | ||
| data-id={id} |
Contributor
There was a problem hiding this comment.
Dit is overbodig geworden?
| UseRowSelectRowProps<D>, | ||
| UseRowStateRowProps<D> {} | ||
| } | ||
| // This file previously augmented the 'react-table' v7 module. |
Contributor
There was a problem hiding this comment.
Kunnen we dit dan niet weg gooien?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://meemoo.atlassian.net/browse/ARC-3762
we'll keep branch
main-with-braft-editoras the old branchand
main-with-tiptapfor the new onethen we can force switch main between these 2 to make new releases
i also propose to use a new major version of the libraries to signify the switch of the RTE