Skip to content

ARC-3691: add useCallbacks to make date selection work #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reunefe merged 1 commit into from
Jun 29, 2026
+85 −81
Merged

ARC-3691: add useCallbacks to make date selection work #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
166 changes: 85 additions & 81 deletions ui/src/react-admin/modules/maintenance-alerts/views/MaintenanceAlertsEditForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,81 +92,89 @@ const MaintenanceAlertsEditForm: FunctionComponent<MaintenanceAlertsEditFormProp
updateFormState();
};

const handleNewFromDate = ((newFromDate: Date | null) => {
if (newFromDate) {
const oldFromDate: Date | null = currentMaintenanceAlert?.fromDate
? parseAsIsoWithoutTimezone(currentMaintenanceAlert.fromDate)
: null;
setCurrentMaintenanceAlert({
...currentMaintenanceAlert,
fromDate: new Date(
newFromDate.getFullYear(),
newFromDate.getMonth(),
newFromDate.getDate(),
oldFromDate?.getHours() || 0,
oldFromDate?.getMinutes() || 0
).toISOString(),
});
}
// biome-ignore lint/suspicious/noExplicitAny: TODO fix
}) as any;

const handleNewFromTime = ((newFromTime: Date | null) => {
if (newFromTime) {
const oldFromDate: Date = currentMaintenanceAlert?.fromDate
? parseAsIsoWithoutTimezone(currentMaintenanceAlert.fromDate)
: new Date();
setCurrentMaintenanceAlert({
...currentMaintenanceAlert,
fromDate: new Date(
oldFromDate?.getFullYear(),
oldFromDate?.getMonth(),
oldFromDate?.getDate(),
newFromTime.getHours(),
newFromTime.getMinutes()
).toISOString(),
});
}
// biome-ignore lint/suspicious/noExplicitAny: TODO fix
}) as any;

const handleNewUntilDate = ((newUntilDate: Date | null) => {
if (newUntilDate) {
const oldUntilDate: Date | null = currentMaintenanceAlert?.untilDate
? parseAsIsoWithoutTimezone(currentMaintenanceAlert.untilDate)
: null;
setCurrentMaintenanceAlert({
...currentMaintenanceAlert,
untilDate: new Date(
newUntilDate.getFullYear(),
newUntilDate.getMonth(),
newUntilDate.getDate(),
oldUntilDate?.getHours() || 23,
oldUntilDate?.getMinutes() || 59
).toISOString(),
});
}
// biome-ignore lint/suspicious/noExplicitAny: TODO fix
}) as any;

const handleNewUntilTime = ((newUntilTime: Date | null) => {
if (newUntilTime) {
const oldUntilDate: Date = currentMaintenanceAlert?.untilDate
? parseAsIsoWithoutTimezone(currentMaintenanceAlert.untilDate)
: new Date();
setCurrentMaintenanceAlert({
...currentMaintenanceAlert,
untilDate: new Date(
oldUntilDate?.getFullYear(),
oldUntilDate?.getMonth(),
oldUntilDate?.getDate(),
newUntilTime.getHours(),
newUntilTime.getMinutes()
).toISOString(),
});
}
// biome-ignore lint/suspicious/noExplicitAny: TODO fix
}) as any;
const handleNewFromDate = useCallback(
(newFromDate: Date | null) => {
if (newFromDate) {
const oldFromDate: Date | null = currentMaintenanceAlert?.fromDate
? parseAsIsoWithoutTimezone(currentMaintenanceAlert.fromDate)
: null;
setCurrentMaintenanceAlert({
...currentMaintenanceAlert,
fromDate: new Date(
newFromDate.getFullYear(),
newFromDate.getMonth(),
newFromDate.getDate(),
oldFromDate?.getHours() || 0,
oldFromDate?.getMinutes() || 0
).toISOString(),
});
}
},
[currentMaintenanceAlert]
);

const handleNewFromTime = useCallback(
(newFromTime: Date | null) => {
if (newFromTime) {
const oldFromDate: Date = currentMaintenanceAlert?.fromDate
? parseAsIsoWithoutTimezone(currentMaintenanceAlert.fromDate)
: new Date();
setCurrentMaintenanceAlert({
...currentMaintenanceAlert,
fromDate: new Date(
oldFromDate?.getFullYear(),
oldFromDate?.getMonth(),
oldFromDate?.getDate(),
newFromTime.getHours(),
newFromTime.getMinutes()
).toISOString(),
});
}
},
[currentMaintenanceAlert]
);

const handleNewUntilDate = useCallback(
(newUntilDate: Date | null) => {
if (newUntilDate) {
const oldUntilDate: Date | null = currentMaintenanceAlert?.untilDate
? parseAsIsoWithoutTimezone(currentMaintenanceAlert.untilDate)
: null;
setCurrentMaintenanceAlert({
...currentMaintenanceAlert,
untilDate: new Date(
newUntilDate.getFullYear(),
newUntilDate.getMonth(),
newUntilDate.getDate(),
oldUntilDate?.getHours() || 23,
oldUntilDate?.getMinutes() || 59
).toISOString(),
});
}
},
[currentMaintenanceAlert]
);

const handleNewUntilTime = useCallback(
(newUntilTime: Date | null) => {
if (newUntilTime) {
const oldUntilDate: Date = currentMaintenanceAlert?.untilDate
? parseAsIsoWithoutTimezone(currentMaintenanceAlert.untilDate)
: new Date();
setCurrentMaintenanceAlert({
...currentMaintenanceAlert,
untilDate: new Date(
oldUntilDate?.getFullYear(),
oldUntilDate?.getMonth(),
oldUntilDate?.getDate(),
newUntilTime.getHours(),
newUntilTime.getMinutes()
).toISOString(),
});
}
},
[currentMaintenanceAlert]
);

const isFormValid = useCallback((): boolean => {
try {
Expand Down Expand Up @@ -435,9 +443,7 @@ const MaintenanceAlertsEditForm: FunctionComponent<MaintenanceAlertsEditFormProp
onBlur={isFormValid}
onChange={handleNewFromDate}
selected={
currentMaintenanceAlert?.fromDate
? new Date(currentMaintenanceAlert.fromDate)
: null
currentMaintenanceAlert?.fromDate ? new Date(currentMaintenanceAlert.fromDate) : null
}
/>

Expand Down Expand Up @@ -482,9 +488,7 @@ const MaintenanceAlertsEditForm: FunctionComponent<MaintenanceAlertsEditFormProp
onBlur={isFormValid}
onChange={handleNewUntilDate}
selected={
currentMaintenanceAlert?.untilDate
? new Date(currentMaintenanceAlert.untilDate)
: null
currentMaintenanceAlert?.untilDate ? new Date(currentMaintenanceAlert.untilDate) : null
}
/>

Expand Down