fix: block Enter submission when submit button is not in DOM - #478
Open
HankGrimm wants to merge 1 commit into
Open
fix: block Enter submission when submit button is not in DOM#478HankGrimm wants to merge 1 commit into
HankGrimm wants to merge 1 commit into
Conversation
Contributor
|
@HankGrimm is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes the Enter-key guard in
PromptInputTextareafromsubmitButton?.disabledto!submitButton || submitButton.disabled.Why
When
PromptInputSubmitrenders as a stop button during streaming (type="button"),form.querySelector('button[type="submit"]')returnsnull. The old guard evaluatesnull?.disabledtoundefined, which is falsy, so the guard never fires — Enter submits a new message mid-stream.Note on behavior change
This also means: if a composed
PromptInputdoesn't renderPromptInputSubmitat all, Enter will now always be blocked (no submit button is ever found in the DOM). Flagging this per the discussion on the issue — happy to adjust if a different default is preferred for that composition case.How verified
Traced the DOM query and type logic; no test suite found for this component (no
prompt-input.test.tsxin the repo) — verification is by code reading, not by running tests.Fixes #439