refactor(vts): extract (reusable) appraisal logic into separate function#377
Open
thomas-fossati wants to merge 1 commit into
Open
refactor(vts): extract (reusable) appraisal logic into separate function#377thomas-fossati wants to merge 1 commit into
thomas-fossati wants to merge 1 commit into
Conversation
thomas-fossati
force-pushed
the
refactor-appraisal
branch
5 times, most recently
from
February 11, 2026 10:06
29a89a1 to
df719da
Compare
| // Appraisal provides an appraisal context internally within the VTS (e.g. for | ||
| // policy evaluation). It is the analog of proto.AppraisalContext, but with a | ||
| // deserialized AttestationResult. | ||
| type Appraisal struct { |
Collaborator
There was a problem hiding this comment.
Just to be clear and to avoid confusion with ear.Appraisal, I prefer we rename this to
AppraisalCtx
Contributor
Author
There was a problem hiding this comment.
I am not super enthusiastic about changing it like this because using AppraisalCtx is too close to the already existing proto.AppraisalContext.
Contributor
Author
There was a problem hiding this comment.
That said, I agree we could improve on Appraisal
yogeshbdeshpande
approved these changes
Feb 17, 2026
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Just few minor corrections on name to help things better!!!
thomas-fossati
force-pushed
the
refactor-appraisal
branch
from
February 17, 2026 14:48
df719da to
08cdf89
Compare
thomas-fossati
marked this pull request as ready for review
February 17, 2026 14:55
thomas-fossati
force-pushed
the
refactor-appraisal
branch
from
February 17, 2026 15:14
08cdf89 to
bbcce67
Compare
Extract (most) of the appraisal logic from GRPC::GetAttestation() into GRPC::getAttestation() so that it can be reused from other RPC service endpoints, e.g., when appraising composite evidence. Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
thomas-fossati
force-pushed
the
refactor-appraisal
branch
from
February 17, 2026 15:51
bbcce67 to
0e63e0d
Compare
github-project-automation
Bot
moved this to Backlog
in Add Support in Veraison to fetch endorsements from Veraison's EDS. Github Issue #387
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract (most) of the appraisal logic from GRPC::GetAttestation() into GRPC::getAttestation() so that it can be reused from other RPC service endpoints, e.g., when appraising composite evidence.
Also, add unit tests for
GRPC::GetAttestation().