feat(http server)!: remove deprecated encoding option - #26082
Draft
pront wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The HTTP server
encodingoption has been deprecated since Vector 0.50.0. Itsmigration window has elapsed, and retaining its compatibility decoder keeps an
obsolete configuration path alive.
Changes
encodingfrom thehttpandhttp_serversource configurations.decodingandframing.Vector configuration
How did you test this PR?
cargo test --lib --no-default-features --features sources-http_server http_server::tests::rejects_removed_encoding_fieldmake VDEV=target/debug/vdev check-clippytarget/debug/vdev check changelog-fragmentstarget/debug/vdev deprecation checkcargo fmt --checkvector validaterejects a configuration containingencoding: text.Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
The removal is recorded as enacted in Vector 0.58.0.