chore(tests): drop influxdb from prometheus integration tests - #26069
chore(tests): drop influxdb from prometheus integration tests#26069thomasqueirozb wants to merge 2 commits into
Conversation
thomasqueirozb
added
the
no-changelog
…te integration tests
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d18da95ff0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| let source: PrometheusRemoteWriteConfig = serde_yaml::from_str(&format!( | ||
| "address: \"{address}\"\n{}", | ||
| tls_yaml.unwrap_or_default() | ||
| )) |
There was a problem hiding this comment.
This replaces the external InfluxDB remote-write receiver with Vector's own prometheus_remote_write source, so the sink integration test is now self-referential: a shared encoder/parser regression can round-trip here while still being rejected by real remote-write services. The mock server above only counts requests, so it also does not preserve the external protocol compatibility check that this integration test used to provide.
AGENTS.md reference: AGENTS.md:L216-L218
Useful? React with 👍 / 👎.
1 participant
Summary
Remove InfluxDB from the prometheus integration tests. The
prometheus_remote_writesink integration tests now use Vector's ownprometheus_remote_writesource as the remote write receiver instead of InfluxDB v1.Vector configuration
NA
How did you test this PR?
Ran
cargo vdev integration run prometheus- all 29 prometheus remote_write integration tests pass with only the Prometheus container (no InfluxDB). Verified the influxdb sink still compiles withsinks-influxdb, and clippy/fmt checks pass.Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References