feat(sinks): validate all sinks at config-compile time by thomasqueirozb · Pull Request #26048 · vectordotdev/vector

thomasqueirozb · 2026-08-06T17:07:02Z

Summary

Extends the validated sink lifecycle to all sinks and makes DynValidatedSink a supertrait of SinkConfig, removing the per-sink as_dyn_validated boilerplate. This also fixes vector validate --no-environment to catch sink configuration errors (including template path-confinement violations) at config-compile time.

Vector configuration

NA

How did you test this PR?

make check-clippy and cargo test -p vector --no-run --features sources-demo_logs.

Is this a breaking change?

Yes
No

Does this PR include user facing changes?

Yes. Please add a changelog fragment based on our guidelines.
No. A maintainer will apply the no-changelog label to this PR.

References

Closes: vector validate --no-environment skips template confinement check #25840

…nment

…ix (#25840)

thomasqueirozb · 2026-08-06T17:07:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

vector/src/sinks/azure_blob/config.rs

Line 287 in 19eef9d

(Some(connstr), None, None) => connstr.inner().into(),

Parse Azure Blob connection strings during validation

For azure_blob configurations that provide a malformed connection_string, this branch just copies the secret into validated state, while ParsedConnectionString::parse and container URL parsing still run later in build_client. Because vector validate --no-environment skips that build path, these pure configuration errors continue to pass compile-time validation; parse and retain the validated connection/container URL state here, deferring only credential construction to build.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

thomasqueirozb · 2026-08-06T19:17:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0eddcfa6ff

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…t validation stays pure

# Conflicts: # src/sinks/azure_blob/config.rs

…le time

…pile time

thomasqueirozb · 2026-08-10T20:21:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7215b709c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

… time

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 346586c9cc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…s, prometheus, pulsar, vector

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c93366efea

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…qs, gcp_chronicle

# Conflicts: # src/sinks/azure_logs_ingestion/tests.rs # src/sinks/azure_monitor_logs/tests.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8ca129e49

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1697d97b20

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-11T22:44:05Z

-        let (sink, healthcheck) = ElasticsearchConfig {
-            endpoints: vec![endpoint],
+        let index =
+            Template::try_from(self.token.inner()).expect("unable to parse token as Template");


Return errors for malformed Sematext tokens

When sematext_logs.token contains invalid template syntax such as foo{{, this expect now runs during sink validation and panics the config compile/vector validate --no-environment path instead of reporting a validation error. Since Template::try_from already returns a Result, propagate that error before building the derived Elasticsearch config so bad user input cannot abort validation.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-11T22:44:05Z

+        // `ElasticsearchCommon::parse_many`).
+        self.common_mode()?;
+
+        let request_limits = self.request.tower.into_settings();


Validate OpenSearch Serverless prerequisites

When elasticsearch uses opensearch_service_type = "serverless" without AWS auth/region, or with a non-auto api_version, this validation still retains success after only endpoint selection and routing-mode checks. ElasticsearchCommon::parse_config rejects those combinations before API-version probing or network I/O, but vector validate --no-environment now skips that build path; mirror the pure Serverless auth/region/API-version checks here.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-11T22:44:06Z

@@ -198,12 +236,41 @@ impl SinkConfig for RemoteWriteConfig {
            .transpose()?;

        let endpoint = self.endpoint.parse::<Uri>().context(UriParseSnafu)?;


Require absolute remote-write endpoints

When prometheus_remote_write.endpoint is a relative URI such as /api/v1/write or lacks a scheme/host, http::Uri still parses successfully here, so validation retains an endpoint that the healthcheck/request path later hands to the HTTP client as a non-absolute target. Since the sink docs require the endpoint to include the scheme and write path, check the parsed URI has a scheme and authority during validation instead of accepting a config that deterministically fails when built or healthchecked.

Useful? React with 👍 / 👎.

thomasqueirozb added 12 commits August 6, 2026 09:58

Migrate all sinks to use ValidatedSink pattern

2558cbe

refactor(sinks): migrate remaining sinks to validated lifecycle

9c9670e

Remove as_dyn_validated from impls into trait

ab5c99c

fix(sinks): disambiguate SinkConfig::build calls in tests

05916a2

docs(opentelemetry sink): correct stale validate comment

6ff7d57

fix(websocket sink): resolve TLS at build time, not during validation

66c3759

chore(changelog): add fragment for aws_s3 ssekms_key_id timezone alig…

3d397af

…nment

feat(datadog_events sink): validate API endpoint at config-compile time

ad4a776

feat(opentelemetry sink): validate HTTP config at config-compile time

6e5f89e

chore(changelog): add fragment for vector validate --no-environment f…

8a6c0dc

…ix (#25840)

fmt

10bc9cf

Fix clippy

19eef9d

chatgpt-codex-connector Bot reviewed Aug 6, 2026

View reviewed changes

thomasqueirozb added 2 commits August 6, 2026 14:11

fix(sinks): validate pure sink config at config-compile time

e10dbf3

fix(azure_blob sink): validate connection string at config-compile time

0eddcfa

github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Aug 6, 2026

chatgpt-codex-connector Bot reviewed Aug 6, 2026

View reviewed changes

Comment thread src/sinks/influxdb/logs.rs

Comment thread src/sinks/databricks_zerobus/config.rs Outdated

Comment thread src/sinks/aws_kinesis/firehose/config.rs

Comment thread src/sinks/console/config.rs Outdated

Comment thread src/sinks/sematext/logs.rs

thomasqueirozb added 6 commits August 6, 2026 15:45

refactor(sinks): use unit validated type for self-cloning sinks

6251ae7

fix(sinks): defer serializer construction to build so --no-environmen…

68f12cb

…t validation stays pure

Merge remote-tracking branch 'origin/master' into sinks-validated-all

3320fcc

# Conflicts: # src/sinks/azure_blob/config.rs

fix(databricks_zerobus sink): validate batch settings at config-compi…

0c2c046

…le time

fix(influxdb_logs sink): resolve log_schema fallbacks at build time

142af49

fix(sematext_logs sink): validate derived Elasticsearch config at com…

f7215b7

…pile time

thomasqueirozb marked this pull request as ready for review August 10, 2026 20:18

thomasqueirozb requested a review from a team as a code owner August 10, 2026 20:18

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Merge remote-tracking branch 'origin/master' into sinks-validated-all

6f2bd9e

thomasqueirozb added 6 commits August 10, 2026 16:54

fix(azure_monitor_logs, redis sinks): validate pure config at compile…

13a46e9

… time

fix(amqp sink): reject zero max_channels during validation

b8c86c2

fix(mqtt sink): validate client id and credentials at compile time

2977eef

fix(nats sink): parse and retain server addresses during validation

984e08c

fix(socket sink): parse and validate TCP address during validation

958607f

fix(websocket sink): parse and validate URI during validation

346586c

github-actions Bot added the domain: sources Anything related to the Vector's sources label Aug 10, 2026

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

thomasqueirozb added 4 commits August 11, 2026 10:45

Simplify aws_cloudwatch_logs validation

3878719

Fix clippy

921831c

fix(sinks): validate TLS configs in nats and greptimedb_metrics

afd9692

fix(sinks): validate pure config errors in azure_blob, kafka, postgre…

c93366e

…s, prometheus, pulsar, vector

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread src/sinks/gcp_chronicle/chronicle_unstructured.rs Outdated

Comment thread src/sinks/aws_s_s/sns/config.rs Outdated

Comment thread src/sinks/http/config.rs

Comment thread src/sinks/socket.rs Outdated

Comment thread src/sinks/elasticsearch/config.rs

thomasqueirozb added 5 commits August 11, 2026 16:10

fix(sinks): defer serializer construction to build for aws_sns, aws_s…

1fe5fbb

…qs, gcp_chronicle

fix(elasticsearch sink): validate endpoint selection during validation

3ccfadf

fix(http sink): validate static URIs during validation

57d19bf

fix(socket sink): validate UDP addresses during validation

8bb3f2d

Merge remote-tracking branch 'origin/master' into sinks-validated-all

b8ca129

# Conflicts: # src/sinks/azure_logs_ingestion/tests.rs # src/sinks/azure_monitor_logs/tests.rs

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

thomasqueirozb added 4 commits August 11, 2026 16:53

Simplify validated sink configs

0f5595c

Validate sink endpoints during config validation

0a372b7

Validate datadog sink endpoints during config validation

efdd234

Fix formatting in datadog traces test imports

1697d97

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

		@@ -198,12 +236,41 @@ impl SinkConfig for RemoteWriteConfig {
		.transpose()?;

		let endpoint = self.endpoint.parse::<Uri>().context(UriParseSnafu)?;

Uh oh!

Conversation

thomasqueirozb commented Aug 6, 2026

Summary

Vector configuration

How did you test this PR?

Is this a breaking change?

Does this PR include user facing changes?

References

Uh oh!

thomasqueirozb commented Aug 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomasqueirozb commented Aug 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomasqueirozb commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!