feat(s3): aws s3 source - add request payer support - #26028
Open
vibe wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
request_payeroption to theaws_s3source. When set torequester, Vector includes the request payer on S3GetObjectcalls so it can read objects from Requester Pays buckets.Leaving the option unset keeps the current behavior.
This also includes the generated config docs, example configuration, tests, and a changelog update.
Vector configuration
How did you test this PR?
Tested locally.
Commands run:
cargo test --lib --no-default-features --features sources-aws_s3 sources::aws_s3
make check-fmt
make check-markdown
make check-changelog-fragments
make generate-docs
VECTOR_BIN=target/debug/vector make -C website validate-config-examples
Is this a breaking change?
Does this PR include user facing changes?
References
I guess on another note, I'm happy to expand the tests, but felt mocking to test the underlying conversion of the passed in option -> aws header....seemed a bit overkill and not our responsibility.