Skip to content

Modernise - #244

Merged
fpseverino merged 6 commits into
mainfrom
modernise
Aug 14, 2026
Merged

Modernise#244
fpseverino merged 6 commits into
mainfrom
modernise

Conversation

@fpseverino

Copy link
Copy Markdown
Member

Add modernisation changes as per Modernisation

@0xTim 0xTim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a long shot, but can any of the unsafe functions be taken over by APIs in Swift System? The answer could well be no, but worth checking

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 22.22222% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.86%. Comparing base (bc341b1) to head (0aa76f8).

Files with missing lines Patch % Lines
...ces/ConsoleKit/Terminal/readpassphrase_linux.swift 7.69% 24 Missing ⚠️
Sources/ConsoleKit/Terminal/Terminal.swift 9.09% 10 Missing ⚠️
Sources/ConsoleKit/Terminal/ANSI.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   71.86%   71.86%           
=======================================
  Files          29       29           
  Lines         878      878           
=======================================
  Hits          631      631           
  Misses        247      247           
Files with missing lines Coverage Δ
Sources/ConsoleKit/Terminal/Console.swift 100.00% <ø> (ø)
Sources/ConsoleLogger/ANSIColor.swift 83.33% <ø> (ø)
...ConsoleLogger/LoggerFragments/LoggerFragment.swift 91.78% <100.00%> (ø)
Sources/ConsoleKit/Terminal/ANSI.swift 85.22% <0.00%> (ø)
Sources/ConsoleKit/Terminal/Terminal.swift 23.68% <9.09%> (ø)
...ces/ConsoleKit/Terminal/readpassphrase_linux.swift 15.00% <7.69%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fpseverino

Copy link
Copy Markdown
Member Author

It's a long shot, but can any of the unsafe functions be taken over by APIs in Swift System? The answer could well be no, but worth checking

At first glance, I think we can only use Swift System in a few lines of linux_readpassphrase, but I’m not sure if it’s worth the effort. Besides, that function is quite specific, so I’d prefer to change it as little as possible

@0xTim 0xTim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pity about all the unsafe stuff but that's the deal with interacting with glibc!

@fpseverino
fpseverino merged commit 5acfda6 into main Aug 14, 2026
24 of 26 checks passed
@fpseverino
fpseverino deleted the modernise branch August 14, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants