Fix failing tests#41
Open
Tejas7007 wants to merge 1 commit into
Open
Conversation
… + update stale mocks to nested coils API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing CI tests so the build passes.
Most of the failures were stale test mocks that no longer matched the
refactored API. The code now nests coil quantities under field.coils
(field.coils.length, biot_savart.coils.currents, and so on), but the mocks
still used the old flat attributes. Updated them to match.
One failure was a real bug in BiotSavart_from_gamma: coils_length,
coils_curvature, r_axis, and z_axis are read-only properties, but init
was assigning to the public names, and the coils_length getter referenced
itself and recursed infinitely. I fixed this by using private backing attributes
(_coils_length, etc.), the same way _gamma_dash already works in that class.