Fix Earth area weight computation for reduced Gaussian grids - #127
Merged
Conversation
Collaborator
Author
|
The failing test is unrelated to this commit (see Unidata/netcdf4-python#1439) and addressed in #128 |
This is expected behavior and we can catch it
uwefladrich
approved these changes
Mar 31, 2026
uwefladrich
left a comment
uwefladrich
left a comment
Owner
There was a problem hiding this comment.
Very good! Only a very small and trivial comment.
Co-authored-by: Uwe Fladrich <49554848+uwefladrich@users.noreply.github.com>
valentinaschueller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #126
This took a bit longer since I noticed that the areas computed from the two methods do not exactly match.
I wanted to verify that they do not differ significantly, and they do not (I checked with two datasets containing only 1s: They differ by about 0.1%).
So I think this is ready to go?