Skip to content

fix: improve Msg91 error handling to extract API error messages #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepshekhardas wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: improve Msg91 error handling to extract API error messages #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c2e0ac
fix: improve Msg91 error handling to extract API error messages
May 14, 2026
a5a921b
fix: guard Msg91 error extraction against non-scalar response fields
Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Utopia/Messaging/Adapter/SMS/Msg91.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,18 @@ protected function process(SMSMessage $message): array
$response->addResult($to);
}
} else {
$errorMessage = 'Unknown error';
if (isset($result['response']['message'])) {
$errorMessage = \is_string($result['response']['message'])
? $result['response']['message']
: \json_encode($result['response']['message']);
} elseif (isset($result['response']['error'])) {
$errorMessage = \is_string($result['response']['error'])
? $result['response']['error']
: \json_encode($result['response']['error']);
}
Comment on lines +104 to +112

@greptile-apps greptile-apps Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Response array type not guarded before key access

request() declares its response field as array<string, mixed>|string|null. When Msg91 returns a non-JSON body (e.g. a plain-text "Unauthorized" or an HTML error page), $result['response'] stays as a raw string. Accessing $result['response']['message'] on a string in PHP coerces the key 'message' to integer 0 and returns the first character of the string — so isset($result['response']['message']) evaluates to true for any non-empty error body, and $errorMessage silently becomes a single character (e.g. "U" for "Unauthorized"). Add an is_array($result['response']) guard before the nested key checks to prevent this.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/Utopia/Messaging/Adapter/SMS/Msg91.php
Line: 104-112

Comment:
**Response array type not guarded before key access**

`request()` declares its `response` field as `array<string, mixed>|string|null`. When Msg91 returns a non-JSON body (e.g. a plain-text "Unauthorized" or an HTML error page), `$result['response']` stays as a raw string. Accessing `$result['response']['message']` on a string in PHP coerces the key `'message'` to integer `0` and returns the first character of the string — so `isset($result['response']['message'])` evaluates to `true` for any non-empty error body, and `$errorMessage` silently becomes a single character (e.g. `"U"` for `"Unauthorized"`). Add an `is_array($result['response'])` guard before the nested key checks to prevent this.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

foreach ($message->getTo() as $to) {
$response->addResult($to, 'Unknown error');
$response->addResult($to, $errorMessage);
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.
}

Expand Down