Skip to content

Upgrade PHP to 8.5 and validators to 0.3.*#918

Closed
Meldiron wants to merge 7 commits into
mainfrom
upgrade-validators-0.3
Closed

Upgrade PHP to 8.5 and validators to 0.3.*#918
Meldiron wants to merge 7 commits into
mainfrom
upgrade-validators-0.3

Conversation

@Meldiron

@Meldiron Meldiron commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Upgrades utopia-php/validators from 0.2.* to 0.3.* and bumps PHP requirement to >=8.5.

Summary by CodeRabbit

  • Chores
    • Updated the minimum supported PHP version to 8.5.
    • Upgraded the validation package to version 0.3.x.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Meldiron, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 81819626-b9cb-4ce9-a0be-dd923d3952b9

📥 Commits

Reviewing files that changed from the base of the PR and between b0641ee and 84e245c.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Dockerfile
📝 Walkthrough

Walkthrough

The Composer configuration now requires PHP 8.5 or newer and utopia-php/validators version 0.3.x. Existing PHP extension requirements remain unchanged.

Changes

Platform Constraints

Layer / File(s) Summary
Update Composer constraints
composer.json
Raises the minimum PHP version from >=8.4 to >=8.5 and upgrades utopia-php/validators from 0.2.* to 0.3.*; existing extensions remain listed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main changes: PHP minimum bumped to 8.5 and validators upgraded to 0.3.*.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-validators-0.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@composer.json`:
- Around line 35-41: Regenerate composer.lock from the updated dependency
constraint in composer.json, ensuring utopia-php/validators resolves to a 0.3.*
version instead of 0.2.2, and commit the resulting lock-file changes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2e17497a-7bbe-4cfc-9114-0ad7fe66f196

📥 Commits

Reviewing files that changed from the base of the PR and between a93cbd1 and b0641ee.

📒 Files selected for processing (1)
  • composer.json

Comment thread composer.json
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the minimum PHP requirement to 8.5, upgrades utopia-php/validators from 0.2.* to 0.3.*, and refactors the Dockerfile to build on php:8.5-cli-alpine with a new multi-stage extension installation strategy that avoids hardcoded extension directory paths.

  • composer.json and composer.lock are cleanly updated; validators 0.3.0 correctly declares php: >=8.5.
  • The Dockerfile refactoring replaces hardcoded no-debug-non-zts-* paths with dynamic $(php-config --extension-dir) resolution, but the loop that builds pgsql, pdo_mysql, and pdo_pgsql only copies .so files \u2014 it never calls docker-php-ext-enable or writes ini files, so these drivers won't be loaded at runtime.

Confidence Score: 4/5

The composer changes are safe; the Dockerfile refactor leaves database extensions unloaded, which will break database tests.

The for-loop in the compile stage builds and copies pgsql, pdo_mysql, and pdo_pgsql but never enables them — no ini files are written and docker-php-ext-enable is not called. Every database test that opens a MySQL or PostgreSQL connection will fail with a missing driver error.

Dockerfile lines 48–50 — the extension enable step is missing for pgsql, pdo_mysql, and pdo_pgsql.

Important Files Changed

Filename Overview
Dockerfile PHP base image upgraded from 8.4 to 8.5, extension build process refactored to copy .so files dynamically; pgsql/pdo_mysql/pdo_pgsql are built but never enabled via ini files, which will break database tests at runtime.
composer.json PHP requirement bumped from >=8.4 to >=8.5 and utopia-php/validators upgraded from 0.2.* to 0.3.* — straightforward and consistent with the lock file and Dockerfile change.
composer.lock Lock file updated to utopia-php/validators 0.3.0 (requires php >=8.5), content-hash regenerated, no other dependency changes.

Reviews (6): Last reviewed commit: "Fix docker-php-ext-install modules path ..." | Re-trigger Greptile

Comment thread composer.json
@Meldiron

Copy link
Copy Markdown
Contributor Author

CLosing in favur of Claude

@Meldiron Meldiron closed this Jul 13, 2026
@Meldiron

Copy link
Copy Markdown
Contributor Author

#919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant