feat:三要素の単語帳を作る機能を追加 - #31
Open
KoshiroIto wants to merge 5 commits into
Open
Conversation
tknkaa
reviewed
Aug 22, 2026
tknkaa
left a comment
tknkaa
left a comment
Contributor
There was a problem hiding this comment.
全体的にはよさそう！
細かいところだけコメントした！
| borderRadius: "16px", | ||
| border: "1px solid rgba(0, 0, 0, 0.18)", | ||
| borderTop: "2px solid rgba(0, 0, 0, 0.3)", | ||
| backgroundColor: "#ffffff", |
Contributor
There was a problem hiding this comment.
ここはインラインではなく、className 側に出してダークモードにも対応するようにしてほしい！
それ以外にもインラインにする必要がないもの（borderRadius, padding, border, boxShadow）は className 側に出そう！
| const is3DMode = columns.length === 3; | ||
|
|
||
| // 3D三角柱のそれぞれの面に入れるコンテンツの準備 | ||
| const primarySense = current?.data.senses[0] || {}; |
Contributor
There was a problem hiding this comment.
これだと多義語でも最初の意味しか表示されないので、余裕があったら別 PR で意味でページネーションするのがいいと思う！
| width: "100%", | ||
| height: "100%", | ||
| // 上から見下ろした時に奥の面が透けて重ならないように設定 | ||
| backfaceVisibility: "visible", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My単語帳 三要素の単語帳（三角柱型）を作成しました。
行った作業は以下です。
・三角柱状のカードを作るコンポーネントを追加
・三つの要素が三角柱のそれぞれの面に出るようにした。
・左右どちらかをクリックしたときに次の要素へ切り替わるようにした。
・作成した単語のリストが三要素のものだった場合、暗記学習を開始した際に上で作成
した三角柱の単語カードで表示されるようにした。