feat: 階層構造の可視化のため、サイドバーを追加 - #30
Open
raito-ctrl wants to merge 2 commits into
Open
Conversation
added 2 commits
August 17, 2026 03:08
tknkaa
reviewed
Aug 22, 2026
tknkaa
left a comment
tknkaa
left a comment
Contributor
There was a problem hiding this comment.
全体的にはよさそう！
細かいところだけコメントした！
Contributor
There was a problem hiding this comment.
コンポーネント関数をデフォルトエクスポートするファイルの名前はパスカルケースにしよう！
sidebar.tsx → Sidebar.tsx
| {/* 言語名のボタン（クリックで言語ページへの遷移とセクション表示のトグル開閉を同時に行う） */} | ||
| <Link | ||
| href={`/learn/${lang.languageSlug}`} | ||
| onClick={() => toggleLanguage(lang.languageSlug)} |
Contributor
There was a problem hiding this comment.
言語名を押しても toggle できるようにするのは割とよくある UI だと思うけど、それなら「My単語帳」と「学習教材」も同じ実装にしたい！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: 階層構造の可視化のため、サイドバーを追加