fix(site): put transfer-set and posted totals back on the card - #124
Draft
c-1k wants to merge 1 commit into
Draft
Conversation
#122 dropped ReceiptArtifact from the verified page. The replacement card printed "transfer-set root" and its meaning without the digest or the pair list (receipt-card.tsx:223-228 on a153f26), and it never rendered postedUsertokens or roundingAdjustment. The display annex still says those chain-committed fields are above. Render the root through HashValue, the pairs when present, and both posted and rounding on the paper slip. Co-Authored-By: Grok 4.6 <grok@x.ai> Signed-off-by: Cam <cam@camwhiteus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence that the #122 Codex P1s still hold on master
Verified against
origin/masterafter #122 (a153f261; current tip also has #123).P1 — transfer-set root and pairs (
site/app/r/components/receipt-card.tsxona153f261, lines 223–228):transfers.rootwas never rendered.transfers.pairshad no mount afterReceiptArtifactleftverified-receipt.tsx. The meaning string for a present list still said the pairs were “below.”P1 — posted / rounding (
verified-receipt.tsxno longer mountsReceiptArtifact; those fields lived only atreceipt-artifact.tsx:172–173). The card invoice showed only the assessed total.CHAIN_COMMITTED_SPEND_FIELDSstill says the totals androundingAdjustmentare “rendered on the receipt above.”What this PR does
On the card’s paper slip:
HashValuefortransfers.root, the pair list whentransferSetis present,postedUsertokens, androundingAdjustment. C1 now asserts the committed root, a pair id, androunding 14 ut.Draft. Do not merge until asked.