Skip to content

Add support for rendering moon's - #90

Open
datryn-ribdun wants to merge 5 commits into
urbit:masterfrom
datryn-ribdun:dr/add-moon
Open

Add support for rendering moon's#90
datryn-ribdun wants to merge 5 commits into
urbit:masterfrom
datryn-ribdun:dr/add-moon

Conversation

@datryn-ribdun

Copy link
Copy Markdown

Closes #89

Adds support for moon sigils on a 4x4 grid

Still needs testing

@matildepark

Copy link
Copy Markdown

I am not quite sure who is best to review this, as the author isn't at Tlon and are sigils even Tlon's or the Foundation's to handle?

@thelifeandtimes

Copy link
Copy Markdown
Member

@jalehman this would be helpful to get reviewed and merged, is @arthryn ~nocsyx-lassul the one who owns this at Tlon? @vcavallo ~sogrum-savluc would be game to help test.

@arthyn

arthyn commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

@thelifeandtimes we'll need to get this updated with the new version before we can merge

@datryn-ribdun datryn-ribdun changed the title WIP: Add support for rendering moon's Add support for rendering moon's Jul 1, 2023
@datryn-ribdun
datryn-ribdun marked this pull request as ready for review July 1, 2023 13:16
@datryn-ribdun

Copy link
Copy Markdown
Author

merged with master and redid the changes. I made a the translate and scale changes entirely in my head so definitely would appreciate a second set of eyes.
I will try to test later this week when I get some free time. What's the easiest way to try out sigil-js locally? Is there a testing env?

@datryn-ribdun

Copy link
Copy Markdown
Author

nvm, I found the nice preview tool. Sadly my npm install is borked will try to resolve and test soon.

@arthyn

arthyn commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

glad to see this picked up. just giving it a glance I see you mention 16 phoneme length, but isn't that for comets not moons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support moons

4 participants