Fix bare except clauses across connection.py, core.py, abstract_launcher.py, __main__.py - #335
Open
koteshyelamati wants to merge 4 commits into
Open
Fix bare except clauses across connection.py, core.py, abstract_launcher.py, __main__.py#335koteshyelamati wants to merge 4 commits into
koteshyelamati wants to merge 4 commits into
Conversation
…cess Replace generic exception handling with specific IndexError handling for command line arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several bare
except:clauses across the codebase catchBaseException, which includesSystemExit,KeyboardInterrupt, andGeneratorExit. This can prevent clean shutdown and mask bugs.Changes
pathos/connection.py(lines 127, 135)Replace bare
except:withexcept Exception:inlaunch(). The handler re-raises asPipeException— there is no reason to catch interpreter signals.pathos/core.py(line 265)Replace bare
except:withexcept Exception:inrandomport(). The handler re-raises asTunnelException.pathos/abstract_launcher.py(line 178)Replace bare
except: passwithexcept Exception: passin_launcher_proxy(). Silently swallowingKeyboardInterruptorSystemExithere would prevent clean process exit.pathos/__main__.py(lines 78, 87, 104, 120)Replace bare
except:withexcept IndexError:forsys.argvaccess. The only exception that can be raised bysys.argv[N]for a missing argument isIndexError— catching everything is overly broad.