Skip to content

backend/postgres: Handle canceled query while scrolling#46

Merged
emilefriot-dev merged 5 commits into
masterfrom
emilefriot/vel-8038-fix-error-wrapping-for-sql-lib
Jul 22, 2026
Merged

backend/postgres: Handle canceled query while scrolling#46
emilefriot-dev merged 5 commits into
masterfrom
emilefriot/vel-8038-fix-error-wrapping-for-sql-lib

Conversation

@emilefriot-dev

Copy link
Copy Markdown
Contributor

What does this PR do?

Allow to correctly handle timeout while scrolling (error is not wrapped elsewhere than Scan).

What are the observable changes?

the postgres timeout error is now mapped in the cursor too, which allows to catch it with the context canceled error on query calls too.

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

Additional Notes

@emilefriot-dev emilefriot-dev self-assigned this Jul 21, 2026
@linear-code

linear-code Bot commented Jul 21, 2026

Copy link
Copy Markdown

VEL-8038

@emilefriot-dev
emilefriot-dev marked this pull request as ready for review July 22, 2026 07:33
@emilefriot-dev
emilefriot-dev requested a review from a team as a code owner July 22, 2026 07:33

@xgoffin xgoffin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle

@emilefriot-dev
emilefriot-dev merged commit 7b2db28 into master Jul 22, 2026
5 checks passed
@emilefriot-dev
emilefriot-dev deleted the emilefriot/vel-8038-fix-error-wrapping-for-sql-lib branch July 22, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants