Add cleanup and deduplication logic to modifier/required-input#692
Merged
Conversation
phndiaye
approved these changes
Jul 22, 2026
Miexil
approved these changes
Jul 22, 2026
JulienVannier66
approved these changes
Jul 22, 2026
aprentout
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We had unstable behavior when the modifier was removed and added again on the same label.
The modifier now cleans up when when destroyed and removes its old * before adding a new one
Related to: #vel-6847
What are the observable changes?
Enregistrement.de.l.ecran.2026-07-22.a.11.29.12.mov
Good PR checklist