Fix calculated height to avoid extra scrollbar for OSS::Select#691
Merged
JulienVannier66 merged 1 commit intoJul 22, 2026
Conversation
JulienVannier66
force-pushed
the
jv/vel-7967/audience-filter-target-dropdown-shows-double-scrollbars
branch
from
July 20, 2026 09:30
773e5f6 to
15d91c0
Compare
JulienVannier66
changed the title
OwenCoogan
approved these changes
Jul 21, 2026
olxmpe
approved these changes
Jul 21, 2026
JulienVannier66
deleted the
jv/vel-7967/audience-filter-target-dropdown-shows-double-scrollbars
branch
July 22, 2026 09:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the max-height calculation of the items list in
OSS::Select. The CSS variables used to subtract the input/button height, padding, and gap from the floating panel height were underestimating the real spacing, so the items container ended up taller than the available space. This created a second, inner scrollbar on top of the floating panel's own scrollbar.What are the observable changes?
Good PR checklist