Merge the Actions menu into the profile pill in the editor toolbar (SDK 0.79.0) - #153
Merged
Merged
Conversation
….79.0) With a document open the dark toolbar had an Actions button pinned to the far left next to Home and an avatar pinned to the far right — the same split the other Universal Apps just removed. Actions now rides in the profile pill at the far right: one control, one dropdown, the PDF's rows above the account rows. Home keeps the far-left margin on its own. FileMenu gains a `rows` variant that returns the menu BODY only, no trigger and no panel, for the SDK's `actions` slot. That works unchanged because the body is a flat accordion list — every submenu expands in place rather than flying out — so it drops into someone else's panel as-is. The `open` state simply stays false there, which parks the outside-click and portal-positioning effects with it. `variant="header"` is untouched and still unused. The pill takes SDK 0.79.0's `pillTheme="dark"`: this bar is slate-900, and the light pill would read as a white chip punched into it rather than one of the bar's buttons. One rename falls out of the merge: the PDF's own "Language" row is now "Document language". It sets `document.documentElement.lang` while the SDK carries the suite-wide UI language, and until now the two lived in separate panels where nobody had to tell them apart. In one dropdown, two rows called "Language" is a coin toss. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015TVwu9Zr3bL9vQDfAcEroy
Deploying universal-pdf with
|
| Latest commit: |
6128ac5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d192e93.universal-pdf-39g.pages.dev |
| Branch Preview URL: | https://claude-nav-editor-chrome-rou.universal-pdf-39g.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a document open the dark toolbar had an Actions button pinned to the far left next to Home and an avatar pinned to the far right — the same split the other Universal Apps just removed. Actions now rides in the profile pill at the far right: one control, one dropdown, the PDF's rows above the account rows. Home keeps the far-left margin on its own.
How it works
FileMenugains arowsvariant that returns the menu body only — no trigger, no panel — for the SDK'sactionsslot.That works unchanged because the body is a flat accordion list: every submenu (File, View, Advanced, Redact, Undo/Redo) expands in place rather than flying out, so it drops into someone else's panel as-is. The
openstate simply stays false in that mode, which parks the outside-click and portal-positioning effects along with it.variant="header"is untouched and still unused.The pill takes SDK 0.79.0's
pillTheme="dark"— this bar is slate-900, and the light pill would read as a white chip punched into it rather than one of the bar's own buttons.One rename falls out of the merge
The PDF's own "Language" row is now "Document language". It sets
document.documentElement.lang, while the SDK's profile menu carries the suite-wide UI language. Until now those lived in separate panels, so nobody had to tell them apart; in one dropdown, two rows called "Language" is a coin toss.Worth a proper decision later: the PDF's picker doesn't actually translate anything, so it may just want deleting in favour of the SDK's.
Verification
npm cifrom an emptynode_modulesand a clean build. Checked by driving the built app in headless Chromium with the example PDF open: home glyph far left, one darkActions ⌄ (avatar)pill far right, and the full menu — Current file, File, View, Advanced, Redact, Undo / Redo, Document language — inside the SDK dropdown above Sign in.Requires
@unisim/sdk0.79.0, published from universal-platform#113.Generated by Claude Code