fix(ioServer): send current frame in ping for client clock sync - #9
Open
andreolli-davide wants to merge 1 commit into
Open
fix(ioServer): send current frame in ping for client clock sync#9andreolli-davide wants to merge 1 commit into
andreolli-davide wants to merge 1 commit into
Conversation
The ping payload emitted lastLatencyData.frame, the frame captured at the previous pong, so it lagged the true frame by ~PING_INTERVAL/CLOCK ticks plus round-trip. Clients anchor their interpolated tick to this frame (anchorFrame = data.frame at receive-time), so the lag skewed every client's tick — and by a different amount per client (independent ping phase + RTT), breaking cross-agent tick comparison. Emit frameAtPing (the frame at emit time) instead. roundTrip stays the previous measurement, which is correct: this ping's RTT is unknown until its pong returns. The latency monitor reads lastLatencyData and is unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ping payload emitted lastLatencyData.frame, the frame captured at the previous pong, so it lagged the true frame by ~PING_INTERVAL/CLOCK ticks plus round-trip. Clients anchor their interpolated tick to this frame (anchorFrame = data.frame at receive-time), so the lag skewed every client's tick, and by a different amount per client (independent ping phase + RTT), breaking cross-agent tick comparison.
Emit frameAtPing (the frame at emit time) instead. roundTrip stays the previous measurement, which is correct: this ping's RTT is unknown until its pong returns. The latency monitor reads lastLatencyData and is unaffected.