🤖 Update ICU4C and ICU4J to 78.3 - #557
Conversation
- Update ICU4C to 78.3 in run_config.json, setup_linux.sh, setup_macos.sh. - Update ICU4J to 78.3 in pom.xml and run_config.json. - Update Node and ICU4X mappings in datasets.py. - Pin CLDR branches for plurals in plurals.py to avoid instability. Co-authored-by: Gemini <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ICU version from 78.1 to 78.3 across various configuration files, setup scripts, and dependency definitions, including pom.xml, run_config.json, setup_linux.sh, and setup_macos.sh. Additionally, it updates the Node and ICU version mappings in testdriver/datasets.py and adds CLDR version mappings for ICU versions 76, 77, and 78 in testgen/generators/plurals.py. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Updates the conformance harness to use ICU 78.3 (ICU4C + ICU4J) and stabilizes plural-rule test generation by pinning CLDR sources to the appropriate maintenance branches for newer ICU versions.
Changes:
- Pin CLDR source branches for plurals generation for ICU 76–78.
- Update version mappings (Node/ICU4X → ICU version) to reflect ICU 78.3.
- Bump harness setup/config and ICU4J Maven dependency from 78.1/78 → 78.3.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
testgen/generators/plurals.py |
Pins CLDR Git branch selection for plurals/ordinals sources for ICU 76–78. |
testdriver/datasets.py |
Updates ICU version lookup maps for Node and ICU4X releases (now including ICU 78.3). |
setup_macos.sh |
Downloads ICU4C 78.3 source tarball for macOS builds. |
setup_linux.sh |
Downloads ICU4C 78.3 Linux binary tarball. |
run_config.json |
Switches ICU4C prereq to 78.3 tarballs; updates Node/ICU4J prereq labels/versions accordingly. |
executors/icu4j/74/executor-icu4j/pom.xml |
Updates ICU4J dependency version to 78.3 under the icu78 profile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| NodeICUVersionMap = { | ||
| '26.3.0': '78.3', | ||
| '24.0.0': '77.1', | ||
| '23.11.0': '76.1', | ||
| '23.3.0': '76.1', | ||
| '22.9.0': '75.1', |
Updates ICU4C and ICU4J executors to version 78.3 in the conformance test harness, replacing the older 78.1/78 versions to avoid overwrite conflicts. Also pins CLDR branches for plurals to avoid instability.
🤖 This pull request was created by an AI agent working with @sffc.