Varyrun fixes #4404
Draft
clmould wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4404 +/- ##
==========================================
+ Coverage 48.80% 48.83% +0.02%
==========================================
Files 151 151
Lines 29348 29400 +52
==========================================
+ Hits 14323 14357 +34
- Misses 15025 15043 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
commented
Jul 1, 2026
clmould
commented
Jul 1, 2026
… at each iteration, and fix finding vars in data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4058
Also fixes varyrun to vary iteration variable values within factor * initial value, instead of updating each iteration
Also small fix to get value of f_nd_impurity_electrons(13) from the in_dat.data instead of from its default value
Checklist
I confirm that I have completed the following checks: