Skip to content

Add confinement mode enum#4401

Merged
timothy-nunn merged 8 commits into
mainfrom
add_confinement_mode_enum
Jul 1, 2026
Merged

Add confinement mode enum#4401
timothy-nunn merged 8 commits into
mainfrom
add_confinement_mode_enum

Conversation

@chris-ashe

Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from a team as a code owner June 30, 2026 14:20
@chris-ashe chris-ashe added Confinement time Plasma energy or particle confinement times Refactor labels Jun 30, 2026
@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.35802% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.82%. Comparing base (bcd37bc) to head (0ab08c5).

Files with missing lines Patch % Lines
process/models/physics/confinement_time.py 16.66% 5 Missing ⚠️
process/core/init.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4401      +/-   ##
==========================================
+ Coverage   48.80%   48.82%   +0.02%     
==========================================
  Files         151      151              
  Lines       29348    29366      +18     
==========================================
+ Hits        14323    14339      +16     
- Misses      15025    15027       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn self-assigned this Jul 1, 2026
Comment thread process/core/init.py Outdated
Comment thread process/core/init.py Outdated
ITPA20_IL = (50, "ITPA20-IL (H)")

def __new__(cls, value: int, full_name: str):
USER_INPUT = (0, "User input electron confinement ", None)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create an issue to handle the formatting and alignment of this string elsewhere because this is getting quite messy

chris-ashe and others added 2 commits July 1, 2026 10:01
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
@chris-ashe chris-ashe requested a review from timothy-nunn July 1, 2026 09:08
@timothy-nunn timothy-nunn enabled auto-merge (squash) July 1, 2026 09:12
@timothy-nunn timothy-nunn disabled auto-merge July 1, 2026 09:29
@timothy-nunn timothy-nunn merged commit 3ef6289 into main Jul 1, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the add_confinement_mode_enum branch July 1, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Confinement time Plasma energy or particle confinement times Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants