feat(stovepipe): add validate controller forwarding commits to batch#255
Open
mnoah1 wants to merge 1 commit into
Open
feat(stovepipe): add validate controller forwarding commits to batch#255mnoah1 wants to merge 1 commit into
mnoah1 wants to merge 1 commit into
Conversation
4ca3b54 to
5d2e6de
Compare
07811a3 to
fbe881a
Compare
fbe881a to
57745ce
Compare
Collaborator
|
This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution. To fix manually: git fetch origin
git checkout mnoah1/stovepipe-validate-controller
git rebase --onto origin/mnoah1/stovepipe-start-wiring fbe881aa56233c566385b3e9a10ceb177555b5f6 mnoah1/stovepipe-validate-controller
# resolve conflicts, then:
git push --force-with-leaseThen update this PR's base branch: gh pr edit 255 --base mnoah1/stovepipe-start-wiring |
57745ce to
aaf851f
Compare
Collaborator
|
This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution. To fix manually: git fetch origin
git checkout mnoah1/stovepipe-validate-controller
git rebase --onto origin/main aaf851f16882bd1876b6f143e9fefb46d56c0949 mnoah1/stovepipe-validate-controller
# resolve conflicts, then:
git push --force-with-leaseThen update this PR's base branch: gh pr edit 255 --base main |
5d2e6de to
862f0b1
Compare
Mirror the start controller's shape for the validate pipeline stage: the validate controller consumes the validate topic, guards the carried partition key, and forwards the change event to the batch stage. Adds the batch topic key, wires the controller into the example orchestrator, and registers the batch topic in the registry. Currently a forwarding stub; placeholder comments describe the eventual commit-metadata resolution per the workflow RFC.
862f0b1 to
d152470
Compare
behinddwalls
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up empty validate controller. This consumes events from the existing start controller, than forwards them to batch if valid. Here, we can implement additional validation logic on a given commit before passing it forward to a batch.
Also wires this into the existing controller
Why?
Building out overall workflow outlined in https://github.com/uber/submitqueue/blob/main/doc/rfc/stovepipe/workflow.md
What?
Validate step in the outline above
Test Plan
make local-stovepipe-startIssue