Persistent output: notify user once instead of console-spamming when the block can't be located#448
Closed
nelsonlove wants to merge 3 commits into
Closed
Conversation
…en the code block can't be located Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… render, not per execution Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ion start Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
Superseded by #449, which includes these commits and rewrites the persistent output path they patch. Closing to reduce reviewer noise — if the smaller change is preferred over the rewrite, this can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With Persistent Output enabled, running a
run-<lang>block (or any block whose editor range can't be resolved, e.g. live preview) logsError finding output target: Probably because of 'run-' prefixto the console on every chunk of stdout, while the user gets no visible indication that their output isn't being saved to the note.This PR:
console.errorspam, and removes thesetViewData(editor.getValue())call in that error path (it rewrote the identical document on every output chunk)console.warnOn-screen output behavior is unchanged.
Testing
npm run buildpasses (tsc + esbuild)run-lispblock now shows the Notice once and produces no per-chunk console errors; the happy path (block range resolved) is untouched by this change🤖 Generated with Claude Code