Skip to content

feat(rtc-tcp-client): deliver received images via on_image callback#6

Merged
sedawwk merged 1 commit into
tuya:masterfrom
xiongzh2000:feat/on-image-recv
Jul 13, 2026
Merged

feat(rtc-tcp-client): deliver received images via on_image callback#6
sedawwk merged 1 commit into
tuya:masterfrom
xiongzh2000:feat/on-image-recv

Conversation

@xiongzh2000

Copy link
Copy Markdown

Server-sent image packets (TAI_PKT_IMAGE — e.g. a cloud-generated picture) were received by the protocol layer but dropped by the dispatcher as an unknown packet type. Surface them to the app:

  • Add tai_image_msg_t + an on_image callback (message-struct API), parsing format/width/height from image-params on START/ONE_SHOT.
  • Handle TAI_PKT_IMAGE in tai_proto_dispatch: strip the 8-byte media header, extract the stream flag, and emit each chunk so the caller reassembles START..END (or a single ONE_SHOT) and decodes the result.
  • Tests: add a downlink image_recv integration test; the forward-compat "unknown packet type" test now uses a reserved type, since IMAGE is a handled type now.

Server-sent image packets (TAI_PKT_IMAGE — e.g. a cloud-generated picture)
were received by the protocol layer but dropped by the dispatcher as an
unknown packet type. Surface them to the app:

- Add tai_image_msg_t + an on_image callback (message-struct API), parsing
  format/width/height from image-params on START/ONE_SHOT.
- Handle TAI_PKT_IMAGE in tai_proto_dispatch: strip the 8-byte media header,
  extract the stream flag, and emit each chunk so the caller reassembles
  START..END (or a single ONE_SHOT) and decodes the result.
- Tests: add a downlink image_recv integration test; the forward-compat
  "unknown packet type" test now uses a reserved type, since IMAGE is a
  handled type now.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@sedawwk sedawwk merged commit e096e25 into tuya:master Jul 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants